Bump dependencies by thomas-zahner · Pull Request #1811 · lycheeverse/lychee

thomas-zahner · 2025-08-21T10:39:06Z

After some efforts I managed to bump all dependencies and get lychee to run again. Most notably I did:

Bump cookie_store for reqwest_cookie_store and requested a new release. Thanks again @pfernie for the quick release.
Fix a bug that was presumably introduced by a behavioural change by reqwest: 7264cc8
Fix flaky test due to ordering issue: 24de64b

Bumps the dependencies group with 22 updates in the / directory: | Package | From | To | | --- | --- | --- | | [anyhow](https://github.com/dtolnay/anyhow) | `1.0.98` | `1.0.99` | | [clap](https://github.com/clap-rs/clap) | `4.5.38` | `4.5.45` | | [headers](https://github.com/hyperium/headers) | `0.4.0` | `0.4.1` | | [openssl-sys](https://github.com/sfackler/rust-openssl) | `0.9.108` | `0.9.109` | | [reqwest](https://github.com/seanmonstar/reqwest) | `0.12.15` | `0.12.18` | | [reqwest_cookie_store](https://github.com/pfernie/reqwest_cookie_store) | `0.8.0` | `0.8.2` | | [serde_json](https://github.com/serde-rs/json) | `1.0.140` | `1.0.142` | | [strum](https://github.com/Peternator7/strum) | `0.27.1` | `0.27.2` | | [tabled](https://github.com/zhiburt/tabled) | `0.19.0` | `0.20.0` | | [tokio](https://github.com/tokio-rs/tokio) | `1.45.1` | `1.47.1` | | [toml](https://github.com/toml-rs/toml) | `0.8.22` | `0.9.5` | | [cookie_store](https://github.com/pfernie/cookie_store) | `0.21.1` | `0.22.0` | | [uuid](https://github.com/uuid-rs/uuid) | `1.17.0` | `1.18.0` | | [wiremock](https://github.com/LukeMathWalker/wiremock-rs) | `0.6.3` | `0.6.4` | | [cached](https://github.com/jaemk/cached) | `0.55.1` | `0.56.0` | | [glob](https://github.com/rust-lang/glob) | `0.3.2` | `0.3.3` | | [html5ever](https://github.com/servo/html5ever) | `0.31.0` | `0.35.0` | | [serde_with](https://github.com/jonasbb/serde_with) | `3.12.0` | `3.14.0` | | [thiserror](https://github.com/dtolnay/thiserror) | `2.0.12` | `2.0.14` | | [typed-builder](https://github.com/idanarye/rust-typed-builder) | `0.21.0` | `0.21.1` | | [rstest](https://github.com/la10736/rstest) | `0.25.0` | `0.26.1` | | [criterion](https://github.com/bheisler/criterion.rs) | `0.6.0` | `0.7.0` | Updates `anyhow` from 1.0.98 to 1.0.99 - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.98...1.0.99) Updates `clap` from 4.5.38 to 4.5.45 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.5.38...clap_complete-v4.5.45) Updates `headers` from 0.4.0 to 0.4.1 - [Release notes](https://github.com/hyperium/headers/releases) - [Commits](hyperium/headers@headers-v0.4.0...headers-v0.4.1) Updates `openssl-sys` from 0.9.108 to 0.9.109 - [Release notes](https://github.com/sfackler/rust-openssl/releases) - [Commits](rust-openssl/rust-openssl@openssl-sys-v0.9.108...openssl-sys-v0.9.109) Updates `reqwest` from 0.12.15 to 0.12.18 - [Release notes](https://github.com/seanmonstar/reqwest/releases) - [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md) - [Commits](seanmonstar/reqwest@v0.12.15...v0.12.18) Updates `reqwest_cookie_store` from 0.8.0 to 0.8.2 - [Changelog](https://github.com/pfernie/reqwest_cookie_store/blob/main/CHANGELOG.md) - [Commits](pfernie/reqwest_cookie_store@v0.8.0...v0.8.2) Updates `serde_json` from 1.0.140 to 1.0.142 - [Release notes](https://github.com/serde-rs/json/releases) - [Commits](serde-rs/json@v1.0.140...v1.0.142) Updates `strum` from 0.27.1 to 0.27.2 - [Release notes](https://github.com/Peternator7/strum/releases) - [Changelog](https://github.com/Peternator7/strum/blob/master/CHANGELOG.md) - [Commits](Peternator7/strum@v0.27.1...v0.27.2) Updates `tabled` from 0.19.0 to 0.20.0 - [Changelog](https://github.com/zhiburt/tabled/blob/master/CHANGELOG.md) - [Commits](https://github.com/zhiburt/tabled/commits) Updates `tokio` from 1.45.1 to 1.47.1 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.45.1...tokio-1.47.1) Updates `toml` from 0.8.22 to 0.9.5 - [Commits](toml-rs/toml@toml-v0.8.22...toml-v0.9.5) Updates `cookie_store` from 0.21.1 to 0.22.0 - [Changelog](https://github.com/pfernie/cookie_store/blob/master/CHANGELOG.md) - [Commits](pfernie/cookie_store@v0.21.1...v0.22.0) Updates `uuid` from 1.17.0 to 1.18.0 - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](uuid-rs/uuid@v1.17.0...v1.18.0) Updates `wiremock` from 0.6.3 to 0.6.4 - [Changelog](https://github.com/LukeMathWalker/wiremock-rs/blob/main/CHANGELOG.md) - [Commits](LukeMathWalker/wiremock-rs@v0.6.3...v0.6.4) Updates `cached` from 0.55.1 to 0.56.0 - [Changelog](https://github.com/jaemk/cached/blob/master/CHANGELOG.md) - [Commits](https://github.com/jaemk/cached/commits) Updates `glob` from 0.3.2 to 0.3.3 - [Release notes](https://github.com/rust-lang/glob/releases) - [Changelog](https://github.com/rust-lang/glob/blob/master/CHANGELOG.md) - [Commits](rust-lang/glob@v0.3.2...v0.3.3) Updates `html5ever` from 0.31.0 to 0.35.0 - [Release notes](https://github.com/servo/html5ever/releases) - [Commits](https://github.com/servo/html5ever/commits/html5ever-v0.35.0) Updates `serde_with` from 3.12.0 to 3.14.0 - [Release notes](https://github.com/jonasbb/serde_with/releases) - [Commits](jonasbb/serde_with@v3.12.0...v3.14.0) Updates `thiserror` from 2.0.12 to 2.0.14 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@2.0.12...2.0.14) Updates `typed-builder` from 0.21.0 to 0.21.1 - [Release notes](https://github.com/idanarye/rust-typed-builder/releases) - [Changelog](https://github.com/idanarye/rust-typed-builder/blob/master/CHANGELOG.md) - [Commits](idanarye/rust-typed-builder@v0.21.0...v0.21.1) Updates `rstest` from 0.25.0 to 0.26.1 - [Release notes](https://github.com/la10736/rstest/releases) - [Changelog](https://github.com/la10736/rstest/blob/master/CHANGELOG.md) - [Commits](la10736/rstest@v0.25.0...v0.26.1) Updates `criterion` from 0.6.0 to 0.7.0 - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.6.0...0.7.0) --- updated-dependencies: - dependency-name: anyhow dependency-version: 1.0.99 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: clap dependency-version: 4.5.45 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: headers dependency-version: 0.4.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: openssl-sys dependency-version: 0.9.109 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: reqwest dependency-version: 0.12.18 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: reqwest_cookie_store dependency-version: 0.8.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: serde_json dependency-version: 1.0.142 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: strum dependency-version: 0.27.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: tabled dependency-version: 0.20.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: tokio dependency-version: 1.47.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: toml dependency-version: 0.9.5 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: cookie_store dependency-version: 0.22.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: uuid dependency-version: 1.18.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: wiremock dependency-version: 0.6.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: cached dependency-version: 0.56.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: glob dependency-version: 0.3.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: html5ever dependency-version: 0.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: serde_with dependency-version: 3.14.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: thiserror dependency-version: 2.0.14 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: typed-builder dependency-version: 0.21.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: rstest dependency-version: 0.26.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: criterion dependency-version: 0.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies ... Signed-off-by: dependabot[bot] <support@github.com>

…no longer valid after bumping dependencies. Probably caused by bumping reqwest

mre · 2025-08-21T11:37:41Z

Good catch! I noticed the same when going through #1805. For future reference, the reqwest change was introduced somewhere between 0.12.15 and 0.12.17. Probably it's in here: https://github.com/seanmonstar/reqwest/releases/tag/v0.12.16.

Either way, we should not have made the assumption that the request URL stayed the same, so it's okay to make that change now. @MichaIng fyi. (Since you worked on that bit in the past. Might be interesting for you to know.)

mre · 2025-08-21T11:38:40Z

Once this PR is fixed and merged, we can rebase #1805 and then cut a new release. A few folks are already waiting on it. 😅

thomas-zahner · 2025-08-21T11:39:50Z

Yes after merging we can do a new release. Really confused why a new test fails all of a sudden now 😅 I'll be investigating it.

MichaIng · 2025-08-21T12:26:55Z

That request URL and response URL are the same was never assumed, at least not by me, redirects etc change it, of course. The fragment however survives redirects, and can only be changed in frontend scripts, which lychee does not execute. So it was assumed that it wouldn't make a difference.

Was the change at reqwest maybe that the response URL has the fragment removed? In any case, it makes more sense to grab the fragment from the request URL, where it is assured to be present 👍.

mre · 2025-08-21T13:34:41Z

Was the change at reqwest maybe that the response URL has the fragment removed?

Yeah, that could be it. Haven't looked into it, though, but it would make sense.

thomas-zahner · 2025-08-21T15:25:46Z

Was the change at reqwest maybe that the response URL has the fragment removed?

Yes that's exactly what happens with the regression test without the bugfix. On master (before bumping) the response URL contains the fragment where on this branch the response URL does not contain the fragment but is otherwise identical. But I haven't investigated more closely why this happens or why reqwest changed this.

…r function

thomas-zahner · 2025-08-21T19:40:49Z

@mre ready for review

mre

Just great 👍

mre · 2025-08-21T20:05:08Z

lychee-bin/tests/cli.rs

+            "subfolder/file2.md",
+            "subfolder/test.html",
+            "markdown.md",
+        ]


Geat abstraction

dependabot bot and others added 5 commits August 21, 2025 11:11

cargo update

fb3fdb9

Use patched fork for reqwest_cookie_store

74b6d16

Fix test after upstream changes to TOML parse error message

3d81576

Fix bug: assumption that request URL is equal to the response URL is …

7264cc8

…no longer valid after bumping dependencies. Probably caused by bumping reqwest

thomas-zahner requested a review from mre August 21, 2025 10:39

Switch back from fork to official dependency

e1d8f08

mre mentioned this pull request Aug 21, 2025

Is Excluding Individual Files Broken? #1620

Closed

thomas-zahner added 2 commits August 21, 2025 21:30

Fix flaky test by ignoring order of expected lines & extract as helpe…

24de64b

…r function

clippy --fix

2cd2959

cargo update

398137d

mre approved these changes Aug 21, 2025

View reviewed changes

lychee-bin/tests/cli.rs

"subfolder/file2.md",

"subfolder/test.html",

"markdown.md",

]

Copy link
Copy Markdown

Member

mre Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geat abstraction

mre merged commit a701990 into lycheeverse:master Aug 21, 2025
6 checks passed

mre mentioned this pull request Aug 21, 2025

chore: release v0.20.0 #1808

Merged

thomas-zahner mentioned this pull request Aug 22, 2025

Does exclude_path support regular expressions? #1608

Closed

thomas-zahner added the triage label Nov 14, 2025

thomas-zahner self-assigned this Nov 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump dependencies#1811

Bump dependencies#1811
mre merged 9 commits intolycheeverse:masterfrom
thomas-zahner:bump-dependencies

thomas-zahner commented Aug 21, 2025 •

edited

Loading

Uh oh!

mre commented Aug 21, 2025

Uh oh!

mre commented Aug 21, 2025

Uh oh!

thomas-zahner commented Aug 21, 2025

Uh oh!

MichaIng commented Aug 21, 2025 •

edited

Loading

Uh oh!

mre commented Aug 21, 2025

Uh oh!

thomas-zahner commented Aug 21, 2025

Uh oh!

thomas-zahner commented Aug 21, 2025

Uh oh!

mre left a comment

Uh oh!

mre Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

thomas-zahner commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mre commented Aug 21, 2025

Uh oh!

mre commented Aug 21, 2025

Uh oh!

thomas-zahner commented Aug 21, 2025

Uh oh!

MichaIng commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mre commented Aug 21, 2025

Uh oh!

thomas-zahner commented Aug 21, 2025

Uh oh!

thomas-zahner commented Aug 21, 2025

Uh oh!

mre left a comment

Choose a reason for hiding this comment

Uh oh!

mre Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thomas-zahner commented Aug 21, 2025 •

edited

Loading

MichaIng commented Aug 21, 2025 •

edited

Loading