Add reader file as a lint check target#226
Open
yjaeseok wants to merge 4 commits intolunchclass:masterfrom
yjaeseok:master
Open
Add reader file as a lint check target#226yjaeseok wants to merge 4 commits intolunchclass:masterfrom yjaeseok:master
yjaeseok wants to merge 4 commits intolunchclass:masterfrom
yjaeseok:master
Conversation
I would like to show command line usage when user type just `$./bacard` So I add command-line-usage package for generate usage contents and then add implement usage in default
Our lint_ts command do not include reader file. So we cannot check lint error in reader file. So I add it. But It is hard to fix no-relative-imports rule. So I would like to this rule disable temporary, Could anyone help me 'how to fix the rule issue?' ISSUE=None
romandev
reviewed
Jan 3, 2018
| "match-default-export-name": false, | ||
| "max-line-length": [true, 80], | ||
| "no-banned-terms": false, | ||
| "no-relative-imports": false, |
Member
There was a problem hiding this comment.
We don't want to allow no-relative-imports.
For reference: //generator/new_parser/parser.ts.
romandev
reviewed
Jan 3, 2018
Member
romandev
left a comment
romandev
left a comment
There was a problem hiding this comment.
Also, if this change works well, you will have to add this file to gulp.task('lint_ts').
Contributor
Author
|
@romandev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our lint_ts command do not include
reader file. So we cannot check lint error
in reader file. So I add it.
But It is hard to fix no-relative-imports rule.
So I would like to this rule disable temporary,
Could anyone help me 'how to fix the rule issue?'
ISSUE=None