Skip to content

fix post_customer() arguments #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

sherrardb
Copy link
Collaborator

 * updated Kavorka signature to remove non-functional or illegitimate argument types
 * removed Net::Stripe::Card and disallowed card id for card, as neither form is valid conceptually <lukec#138>
 * always create a Net::Stripe::Customer object before _post() to take advantage of argument coercion during objectification <lukec#148>
 * include omitted arguments in object creation
 * clean up and centralize Net::Stripe:Token coercion code, since we always need the token id
 * added unit tests to exercise all allowed argument forms for customer creation and customer update <lukec#139>
 * closes <lukec#138>
@sherrardb sherrardb merged commit 3151556 into lukec:master Jan 22, 2020
@sherrardb sherrardb deleted the fix-post-customer-args branch January 22, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

card object and card id not legitimate arguments to post_customer() and post_card()
1 participant