cannot update attributes for existing customer card

[sherrardb]

this may be due to my own bone-headedness, but i cannot seem to identify a code path that allows one to update the attributes of an existing customer card. the docs indicate that you can post updated attributes for an existing card via a URL of the form https://api.stripe.com/v1/customers/{CUSTOMER_ID}/sources/{CARD_ID}. but of all of the incantations of post_charge() and post_customer() which i tried, passing combinations of either the id or the object for the card and customer arguments, none seemed to work. and my reading of the code seems to indicate the same. of course i hope that i am simply missing something.

please have a look at sherrardb:cannot_update_existing_card and let me know what further you need from me.

[sherrardb]

specifically, i cannot identify the calling form that would allow us to fall into this block in post_card:

        if (ref($card) eq 'HASH') {
            $card = Net::Stripe::Card->new($card);
        }
        if (defined($card->id)) {
            return $self->_post("customers/$customer/cards/" . $card->id, $card);
        }

which, AFAICT is the only way to trigger a card update. but it seems that the only way to have a card id is to pass in a Net::Stripe::Card object, which causes us to exit the sub a few lines earlier:

        # Update the card.
        if (ref($card) eq 'Net::Stripe::Card' && $card->id) {
            return $self->_post("customers/$customer/cards", $card);
        }

but my testing and reading seems to indicate that to update an existing card, you need the card id, but the arguments are passed at the top level, not nested, ie name=John+Doe, not in card[name]=John+Doe, meaning that even if the Net::Stripe::Card object was passed, and the URL were correct, we would not have the correct argument format.

[sherrardb]

after prototyping some code to leverage an update_card method that i mocked up, i have concluded that while it would be nice to provide developers with an access point into this part of the API, it is not useful for me from an operational perspective because making use of it would require building a card management interface that allows users to select an existing card and a dedicated form UI, validation, etc to collect the updated address and expiration info, when it is much easier to use Stripe checkout to collect all of the card information and replace the existing card wholesale with post_customer().

i have created the unit tests, and mocked up the method in sherrardb:cannot_update_existing_card so that it can still be considered for refinement and inclusion.

[sherrardb]

the final set of changes for this update are found in sherrardb:f-cannot-update-existing-card

[sherrardb]

i was revisiting the code above, and i thought i should add some further clarification about the issue raised while it is fresh in my mind.

    method post_card(Net::Stripe::Customer|Str :$customer,
                     HashRef|Net::Stripe::Card|Net::Stripe::Token|Str :$card) {
        if (ref($customer)) {
            $customer = $customer->id;
        }
        if (! ref($card) && $card =~ /^tok_.+/) {
            return $self->_post("customers/$customer/cards", {card=> $card});
        }
        if (ref($card) eq 'Net::Stripe::Token' && $card->id) {
            return $self->_post("customers/$customer/cards", {card=> $card->id});
        }
        # Update the card.
        if (ref($card) eq 'Net::Stripe::Card' && $card->id) {
            return $self->_post("customers/$customer/cards", $card);
        }
        if (ref($card) eq 'HASH') {
            $card = Net::Stripe::Card->new($card);
        }
        if (defined($card->id)) {
            return $self->_post("customers/$customer/cards/" . $card->id, $card);
        }
warn "executing fall-through return statement\n";
        return $self->_post("customers/$customer/cards", $card);
    }

posting a new Net::Stripe::Card object to a customer falls through to the final return statement, since there is no $card->id:

~$ perl -Mstrict -Mwarnings -mNet::Stripe -e 'my $stripe = Net::Stripe->new(api_key => $ENV{STRIPE_API_KEY});
my $fake_card = {
  number=> "4242-4242-4242-4242",
  exp_month=> 12,
  exp_year=> 2030,
  cvc=> 123,
  name=> "Anonymous",
  metadata=> { "somecardmetadata"=> "testing, testing, 1-2-3", },
  address_line1=> "123 Main Street",
  address_city=> "Anytown",
  address_state=> "Anystate",
  address_zip=> "55555",
  address_country=> "United States"
};
my $customer = $stripe->post_customer();
my $card = Net::Stripe::Card->new( %{$fake_card} );
$stripe->post_card( customer=> $customer, card=> $card );'
executing fall-through return statement

and posting an existing Net::Stripe::Card object to a customer (while pointless anyway, since you cannot update the card attributes) actually dies:
(note that the warn output here is from the initial posting of the hashref)

~$ perl -Mstrict -Mwarnings -mNet::Stripe -e 'my $stripe = Net::Stripe->new(api_key => $ENV{STRIPE_API_KEY});
my $fake_card = {
  number=> "4242-4242-4242-4242",
  exp_month=> 12,
  exp_year=> 2030,
  cvc=> 123,
  name=> "Anonymous",
  metadata=> { "somecardmetadata"=> "testing, testing, 1-2-3", },
  address_line1=> "123 Main Street",
  address_city=> "Anytown",
  address_state=> "Anystate",
  address_zip=> "55555",
  address_country=> "United States"
};
my $customer = $stripe->post_customer();
my $card = $stripe->post_card( customer=> $customer, card=> $fake_card );
$stripe->post_card( customer=> $customer, card=> $card );'
executing fall-through return statement
Error: invalid_request_error - Missing required param: card[number]. On parameter: card[number]
Card error: parameter_missing

so not only is that block ineffectual in updating the card (which was previously my only assertion), it is actively broken, and should be removed

[sherrardb]

correction, you can update one card attribute:

stripe-perl/lib/Net/Stripe/Card.pm

Line 19 in 646861d

has 'metadata' => (is => 'rw', isa => 'Maybe[HashRef]');

and i'm pretty sure that this was a copy and paste mistake by me during 267f0b6.

but i have confirmed that even when updating the metadata on an existing card object and passing it to post-card(), the API call still fails because of how the card object is serialized at the top level.

~$ perl -Mstrict -Mwarnings -mNet::Stripe -e 'my $stripe = Net::Stripe->new(api_key => $ENV{STRIPE_API_KEY});
my $fake_card = {
  number=> "4242-4242-4242-4242",
  exp_month=> 12,
  exp_year=> 2030,
  cvc=> 123
};
my $customer = $stripe->post_customer();
my $card = $stripe->post_card( customer=> $customer->id, card=> $fake_card );
$card->metadata( { somenewmetadata=> "hello world" } );
$stripe->post_card( customer=> $customer->id, card=> $card );'
Error: invalid_request_error - Received unknown parameter: card On parameter: card
Card error: parameter_unknown

just wanted to note that for the sake of completeness.