Skip to content

RUN_ONLY_ONCE by default#362

Open
naworm wants to merge 1 commit into
luigi311:mainfrom
naworm:main
Open

RUN_ONLY_ONCE by default#362
naworm wants to merge 1 commit into
luigi311:mainfrom
naworm:main

Conversation

@naworm

@naworm naworm commented Jun 16, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Chores
    • Updated script execution mode to run once on startup instead of continuous operation.
    • Modified Docker Compose service restart policy to prevent automatic restarts.
    • Adjusted environment variable configuration loading method.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The sample environment file changes RUN_ONLY_ONCE from "False" to "True". The docker-compose.yml updates the jellyplex-watched service's restart policy from unless-stopped to no and simplifies the env_file path from ./.env to .env.

Changes

Run-once configuration alignment

Layer / File(s) Summary
Run-once env default and compose service policy
.env.sample, docker-compose.yml
RUN_ONLY_ONCE default set to "True" in the sample env file; docker-compose restart policy changed to no and env_file path simplified to .env.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 One hop, then done — no loop for me!
The container rests once it runs free.
No unless-stopped, just no to spin,
RUN_ONLY_ONCE set true within.
A tidy burrow, neat and bright! 🌟

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating RUN_ONLY_ONCE to be enabled by default in .env.sample, which is the primary modification in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.env.sample:
- Line 10: Remove the spaces around the equals sign in the RUN_ONLY_ONCE
assignment in the .env.sample file. Change RUN_ONLY_ONCE = "True" to
RUN_ONLY_ONCE="True" to comply with dotenv-linter rules and maintain consistent
environment variable parsing behavior.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 03c3c9ef-5e2a-4d24-b1c9-429d5142d98a

📥 Commits

Reviewing files that changed from the base of the PR and between 088a6d5 and de4e1c0.

📒 Files selected for processing (2)
  • .env.sample
  • docker-compose.yml

Comment thread .env.sample

## If set to true then the script will only run once and then exit
RUN_ONLY_ONCE = "False"
RUN_ONLY_ONCE = "True"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove spaces around = in the changed env assignment.

RUN_ONLY_ONCE = "True" triggers dotenv-linter [SpaceCharacter]; use RUN_ONLY_ONCE="True" to keep env parsing/lint behavior consistent.

🧰 Tools
🪛 dotenv-linter (4.0.0)

[warning] 10-10: [SpaceCharacter] The line has spaces around equal sign

(SpaceCharacter)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.env.sample at line 10, Remove the spaces around the equals sign in the
RUN_ONLY_ONCE assignment in the .env.sample file. Change RUN_ONLY_ONCE = "True"
to RUN_ONLY_ONCE="True" to comply with dotenv-linter rules and maintain
consistent environment variable parsing behavior.

Source: Linters/SAST tools

@luigi311

Copy link
Copy Markdown
Owner

Why was this submitted? The point of this is to have it running in a loop and have it sync up every X amount of time specified and not to constantly go in and call docker up or start the container.

@naworm

naworm commented Jun 16, 2026

Copy link
Copy Markdown
Author

Why was this submitted? The point of this is to have it running in a loop and have it sync up every X amount of time specified and not to constantly go in and call docker up or start the container.

your tool is great.
imo, the default use case is to migrate from one tool to another.
my use case is to obliterate plex and only use jellyfin. for that, i only need to run it once.
synchronization seems to be the second use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants