-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Show proper default key name in reset tooltip on keybindings menu #16777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
SmallJoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does work. At least as long as the key exists.

According to https://wiki.libsdl.org/SDL3/SDL_Scancode , respectively the USB standard https://gist.github.com/mildsunrise/4e231346e2078f440969cdefb6d4caa3 this should refer to the + key, which does not exist on my keyboard.
Fair enough. Works.
y5nw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the key to the left of the backspace key, which is a dead key on some layouts (dead acute on the German layout, dead circumflex on a Swiss one). SDL does not report a keycode for this, so the scancode is displayed. |
y5nw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works

Fixes #16515
This PR fixes an issue in the keybindings menu where the reset button shows a cryptic tooltip such as "Reset setting to default (SYSTEM_SCANCODE_##)".
This also adds a new core function for the main menu
core.get_key_description()to take a scancode and convert it to the human-readable name that is already available in KeyPress.To do
This PR is Ready for Review.
How to test