fix: remove ENR cache from peer exchange (#3578)

[fcecin]

Description

This PR removes the ENR cache and the worker loop that fed it in WakuPeerExchange, and replaces it with a direct query to the PeerStore. To avoid slowdowns, the new getEnrsFromStore doesn't allocate any memory other than the resulting sequence of ENR records to the caller.

Changes

• remove WakuPeerExchange.enrCache
• add forEnrPeers to support fast PeerStore search
• add getEnrsFromStore
• fix peer exchange tests

Issue

closes #3578

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3652

Built from 4696901

[Ivansete-status]

LGTM! Thanks for it! 💯
Just adding some nitpicks that I hope you find useful

[fcecin]

NOTE: the ci.yml workflow is broken, likely due to the project name change.

It was blowing up on line 135 of ci.yml. I changed it to:

uses: logos-messaging/nwaku/.github/workflows/container-image.yml@master

Now it blows up on line 140, which still references waku.org.

[fryorcraken]

NOTE: the ci.yml workflow is broken, likely due to the project name change.

It was blowing up on line 135 of ci.yml. I changed it to:

uses: logos-messaging/nwaku/.github/workflows/container-image.yml@master

Now it blows up on line 140, which still references waku.org.

Can you do a dedicated PR to fixing the CI so we can get it merged asap (feel free to ping me for review)?

[fcecin]

NOTE: the ci.yml workflow is broken, likely due to the project name change.
It was blowing up on line 135 of ci.yml. I changed it to:

uses: logos-messaging/nwaku/.github/workflows/container-image.yml@master

Now it blows up on line 140, which still references waku.org.

Can you do a dedicated PR to fixing the CI so we can get it merged asap (feel free to ping me for review)?

On it

[NagyZoltanPeter]

Awsome, thank you! Added one recommendation for the template if you may consider to apply.