Skip to content

chore: removing protected-topic cli flag#3160

Merged
gabrielmer merged 1 commit intomasterfrom
chore-remove-protected-topic-flag
Oct 31, 2024
Merged

chore: removing protected-topic cli flag#3160
gabrielmer merged 1 commit intomasterfrom
chore-remove-protected-topic-flag

Conversation

@gabrielmer
Copy link
Copy Markdown
Contributor

Description

Removing protected-topic CLI flag

Issue

closes #2984

@github-actions
Copy link
Copy Markdown

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3160

Built from b7a4b4c

Copy link
Copy Markdown
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to clean this up too but I think we need to perform some previous work to adapt the current status fleets' configurations and maybe use protected-shards instead:
https://github.com/status-im/infra-status/blob/d319a1e405cdf1ca18b60d2a2fd19ff629d18194/ansible/group_vars/store.yml#L30-L33

@gabrielmer
Copy link
Copy Markdown
Contributor Author

I'd like to clean this up too but I think we need to perform some previous work to adapt the current status fleets' configurations and maybe use protected-shards instead: https://github.com/status-im/infra-status/blob/d319a1e405cdf1ca18b60d2a2fd19ff629d18194/ansible/group_vars/store.yml#L30-L33

Ooh good catch! I think it's just a matter of adding the new variable to the infra repo and use the new format, shouldn't be an issue I think. Or is there a longer process to follow?

Copy link
Copy Markdown
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for it!

@gabrielmer gabrielmer merged commit 8fde709 into master Oct 31, 2024
@gabrielmer gabrielmer deleted the chore-remove-protected-topic-flag branch October 31, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove protectedTopic config item

3 participants