feat: adding waku_dial_peer and get_connected_peers to libwaku#3149
Merged
gabrielmer merged 7 commits intomasterfrom Oct 30, 2024
Merged
feat: adding waku_dial_peer and get_connected_peers to libwaku#3149gabrielmer merged 7 commits intomasterfrom
gabrielmer merged 7 commits intomasterfrom
Conversation
|
You can find the image built from this PR at Built from af29e62 |
gabrielmer
force-pushed
the
feat-add-dialpeer-to-libwaku
branch
from
b28101e to
f76154d
Compare
gabrielmer
changed the title
4 tasks
gabrielmer
requested review from
Ivansete-status,
NagyZoltanPeter,
darshankabariya and
richard-ramos
Collaborator
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
Thanks! For it! Just added a couple of comments that I hope you find useful
| return err($error) | ||
| let conn = await waku.node.peerManager.dialPeer(peerId, $self[].protocol) | ||
| if conn.isNone(): | ||
| if $self[].protocol != "" and conn.isNone(): |
Collaborator
There was a problem hiding this comment.
How we should handle the condition of $self[].protocol == "" and conn.isNone()?
The same question applies to the DIAL_PEER operation:)
gabrielmer
force-pushed
the
feat-add-dialpeer-to-libwaku
branch
from
f76154d to
cbd2f83
Compare
Ivansete-status
approved these changes
Oct 30, 2024
Collaborator
Ivansete-status
left a comment
Ivansete-status
left a comment
There was a problem hiding this comment.
LGTM! Thanks for it! 💯
library/waku_thread/inter_thread_communication/requests/peer_manager_request.nim
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding new procedures to libwaku to be able to dial peers using a specific protocol and to be able to retrieve the peerIds of all connected nodes
Changes
waku_dial_peerto libwakuwaku_get_connected_peersto libwakuwaku_dial_peer_by_idIssue
#3076