Skip to content

Conversation

keith
Copy link
Member

@keith keith commented Jun 7, 2024

It looks like this FIXME was resolved when the last use of this was
removed in 085f078

It looks like this FIXME was resolved when the last use of this was
removed in 085f078
@llvmbot
Copy link
Member

llvmbot commented Jun 7, 2024

@llvm/pr-subscribers-testing-tools

Author: Keith Smiley (keith)

Changes

It looks like this FIXME was resolved when the last use of this was
removed in 085f078


Full diff: https://github.com/llvm/llvm-project/pull/94804.diff

1 Files Affected:

  • (modified) llvm/utils/lit/lit/llvm/config.py (-5)
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index afb7f078072fc..30abb539d6647 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -88,14 +88,9 @@ def __init__(self, lit_config, config):
             ]
         )
 
-        # Running on Darwin OS
         if platform.system() == "Darwin":
-            # FIXME: lld uses the first, other projects use the second.
-            # We should standardize on the former.
-            features.add("system-linker-mach-o")
             features.add("system-darwin")
         elif platform.system() == "Windows":
-            # For tests that require Windows to run.
             features.add("system-windows")
         elif platform.system() == "Linux":
             features.add("system-linux")

Copy link
Member

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments about the OS are inconsistent, so removing these two outliers here also LGTM.

@arichardson
Copy link
Member

Sorry if that was ambiguous, I meant to say removing the comments is fine - no need to add them back. Feel free to land whichever version you prefer.

@keith keith merged commit 511a195 into llvm:main Jun 11, 2024
@keith keith deleted the ks/llvm-lit-remove-unused-default-feature branch June 11, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants