Skip to content

[clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions #90717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2024
Merged

[clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment instructions #90717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94c812a
[clang][PGO] Apply artificial DebugLoc to llvm.instrprof.increment in…
Michael137 May 1, 2024
8fc35f6
fixup! make FileCheck pattern less strict. Resolve Linux/Windows test…
Michael137 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/CodeGen/CodeGenFunction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,8 +1587,10 @@ class CodeGenFunction : public CodeGenTypeCache {
void incrementProfileCounter(const Stmt *S, llvm::Value *StepV = nullptr) {
if (CGM.getCodeGenOpts().hasProfileClangInstr() &&
!CurFn->hasFnAttribute(llvm::Attribute::NoProfile) &&
!CurFn->hasFnAttribute(llvm::Attribute::SkipProfile))
!CurFn->hasFnAttribute(llvm::Attribute::SkipProfile)) {
auto AL = ApplyDebugLocation::CreateArtificial(*this);
PGO.emitCounterSetOrIncrement(Builder, S, StepV);
}
PGO.setCurrentStmt(S);
}

Expand Down
40 changes: 40 additions & 0 deletions clang/test/Profile/debug-info-instr_profile_switch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// Tests that we don't attach misleading debug locations to llvm.instrprof.increment
// counters.

// RUN: %clang_cc1 -x c++ %s -debug-info-kind=standalone -triple %itanium_abi_triple -main-file-name debug-info-instr_profile_switch.cpp -std=c++11 -o - -emit-llvm -fprofile-instrument=clang | FileCheck %s

int main(int argc, const char *argv[]) {
switch(argc) {
case 0:
return 0;
case 1:
return 1;
}
}

// CHECK: define {{.*}} @main(i32 noundef %argc, ptr noundef %argv) #0 !dbg ![[MAIN_SCOPE:[0-9]+]]

// CHECK: switch i32 {{.*}}, label {{.*}} [
// CHECK-NEXT: i32 0, label %[[CASE1_LBL:[a-z0-9.]+]]
// CHECK-NEXT: i32 1, label %[[CASE2_LBL:[a-z0-9.]+]]
// CHECK-NEXT: ], !dbg ![[SWITCH_LOC:[0-9]+]]

// CHECK: [[CASE1_LBL]]:
// CHECK-NEXT: %{{.*}} = load i64, ptr getelementptr inbounds ({{.*}}, ptr @__profc_main, {{.*}}), align {{.*}}, !dbg ![[CTR_LOC:[0-9]+]]
// CHECK-NEXT: %{{.*}} = add {{.*}}, !dbg ![[CTR_LOC]]
// CHECK-NEXT: store i64 {{.*}}, ptr getelementptr inbounds ({{.*}}, ptr @__profc_main, {{.*}}), align {{.*}}, !dbg ![[CTR_LOC]]
// CHECK-NEXT: store i32 0, {{.*}} !dbg ![[CASE1_LOC:[0-9]+]]
// CHECK-NEXT: br label {{.*}}, !dbg ![[CASE1_LOC]]

// CHECK: [[CASE2_LBL]]:
// CHECK-NEXT: %{{.*}} = load i64, ptr getelementptr inbounds ({{.*}}, ptr @__profc_main, {{.*}}), align {{.*}}, !dbg ![[CTR_LOC]]
// CHECK-NEXT: %{{.*}} = add {{.*}}, !dbg ![[CTR_LOC]]
// CHECK-NEXT: store i64 {{.*}}, ptr getelementptr inbounds ({{.*}}, ptr @__profc_main, {{.*}}), align {{.*}}, !dbg ![[CTR_LOC]]
// CHECK-NEXT: store i32 1, {{.*}} !dbg ![[CASE2_LOC:[0-9]+]]
// CHECK-NEXT: br label {{.*}}, !dbg ![[CASE2_LOC]]

// CHECK: ![[SWITCH_LOC]] = !DILocation({{.*}}, scope: ![[MAIN_SCOPE]])
// CHECK: ![[CTR_LOC]] = !DILocation(line: 0, scope: ![[BLOCK_SCOPE:[0-9]+]])
// CHECK: ![[BLOCK_SCOPE]] = distinct !DILexicalBlock(scope: ![[MAIN_SCOPE]]
// CHECK: ![[CASE1_LOC]] = !DILocation(line: {{.*}}, column: {{.*}}, scope: ![[BLOCK_SCOPE]])
// CHECK: ![[CASE2_LOC]] = !DILocation(line: {{.*}}, column: {{.*}}, scope: ![[BLOCK_SCOPE]])