Skip to content

[Release] Build default target during Phase 1 and 2 on AIX #81009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Release] Build default target during Phase 1 and 2 on AIX #81009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions llvm/utils/release/test-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,11 +528,11 @@ function build_llvmCore() {
LitVerbose="-v"

InstallTarget="install"
if [ "$Phase" -lt "3" ]; then
# compiler-rt builtins is needed on AIX to have a functional Phase 1 clang.
if [ "$Phase" -lt "3" ] && [ "$System" != "AIX" ]; then
Comment on lines +531 to +532
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is insulating AIX from the broader effects of the code here (to reduce the phase 1 and 2 builds) entirely. It should be possible to just add the necessary additional targets for AIX.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is more of a temporary solution for now since I'm still not sure why the original code is skipping the compiler-rt build during phase 1. Once I've investigated the problem more I'll update the fix.

BuildTarget="clang"
InstallTarget="install-clang install-clang-resource-headers"
# compiler-rt builtins is needed on AIX to have a functional Phase 1 clang.
if [ "$System" = "AIX" -o "$Phase" != "1" ]; then
if [ "$Phase" != "1" ]; then
BuildTarget="$BuildTarget runtimes"
InstallTarget="$InstallTarget install-runtimes"
fi
Expand Down