-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[mlir][sparse] setup SparseIterator
to help generating code to traverse a sparse tensor level.
#78345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a30f817
to
7d4fe20
Compare
aartbik
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup in loop emitter with a better abstraction!
(but also a lot of new code in sparse tensor level))
Here is a first wave of comments, will dive deeper into sparse tensor level after that
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorLevel.h
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorLevel.cpp
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorLevel.cpp
Outdated
Show resolved
Hide resolved
mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorLevel.cpp
Outdated
Show resolved
Hide resolved
73df711
to
5dcb849
Compare
aartbik
reviewed
Jan 24, 2024
5dcb849
to
f97bf75
Compare
aartbik
approved these changes
Jan 24, 2024
mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorLevel.h
Outdated
Show resolved
Hide resolved
651be78
to
fb2105a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.