Skip to content

[LLDB] Don't forcefully initialize the process trace plugin #71455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023
+5 −7
Merged

[LLDB] Don't forcefully initialize the process trace plugin #71455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lldb/source/API/SystemInitializerFull.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ llvm::Error SystemInitializerFull::Initialize() {
#define LLDB_PLUGIN(p) LLDB_PLUGIN_INITIALIZE(p);
#include "Plugins/Plugins.def"

// Initialize plug-ins in core LLDB
ProcessTrace::Initialize();

// Scan for any system or user LLDB plug-ins
PluginManager::Initialize();

Expand Down
9 changes: 5 additions & 4 deletions lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,11 @@ TraceIntelPTBundleLoader::CreateEmptyProcess(lldb::pid_t pid,
ParsedProcess parsed_process;
parsed_process.target_sp = target_sp;

ProcessSP process_sp = target_sp->CreateProcess(
/*listener*/ nullptr, "trace",
/*crash_file*/ nullptr,
/*can_connect*/ false);
// This should instead try to directly create an instance of ProcessTrace.
// ProcessSP process_sp = target_sp->CreateProcess(
// /*listener*/ nullptr, "trace",
// /*crash_file*/ nullptr,
// /*can_connect*/ false);

process_sp->SetID(static_cast<lldb::pid_t>(pid));

Expand Down