Skip to content

[LLD] [COFF] Fix deducing the machine type from LTO objects for ARM/Thumb #71335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[LLD] [COFF] Fix deducing the machine type from LTO objects for ARM/Thumb #71335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lld/COFF/InputFiles.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,6 +1090,7 @@ MachineTypes BitcodeFile::getMachineType() {
case Triple::x86:
return I386;
case Triple::arm:
case Triple::thumb:
return ARMNT;
case Triple::aarch64:
return ARM64;
Expand Down
19 changes: 19 additions & 0 deletions lld/test/COFF/lto-arm.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
; REQUIRES: arm

; RUN: llvm-as %s -o %t.obj

; RUN: lld-link /entry:entry %t.obj /out:%t.exe /subsystem:console 2>&1 | FileCheck %s --check-prefix=ERR --allow-empty
; RUN: llvm-readobj %t.exe | FileCheck %s

; ERR-NOT: /machine is not specified

; CHECK: Format: COFF-ARM{{$}}
; CHECK: Arch: thumb

target datalayout = "e-m:w-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
target triple = "thumbv7-w64-windows-gnu"

define dso_local arm_aapcs_vfpcc void @entry() {
entry:
ret void
}