Skip to content

Make sure all matrix options are run in libc premerge testing #146162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+22 −5
Open

Make sure all matrix options are run in libc premerge testing #146162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38cf8c9
Make sure all matrix options are run in the libc premerge testing
amykhuang Jun 27, 2025
f5a6e45
Try to only build all of debug/release/minsizerel on linux fullbuilds
amykhuang Jun 30, 2025
3191cb9
Trying to figure out how the matrix works
amykhuang Jun 30, 2025
917a60d
Fix again
amykhuang Jun 30, 2025
d3a320e
Fix cmake var and remove extra line passing a MinSizeRel config
amykhuang Jul 2, 2025
5887557
add back release mode
amykhuang Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions .github/workflows/libc-fullbuild-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,40 @@ jobs:
strategy:
fail-fast: false
matrix:
build_type: [Debug, Release, MinSizeRel]
# Build basic linux configuration with Debug/Release/MinSizeRel and all
# other configurations in Debug only.
include:
- os: ubuntu-24.04
build_type: Debug
ccache-variant: sccache
c_compiler: clang-21
cpp_compiler: clang++-21
target: x86_64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: Release
ccache-variant: sccache
c_compiler: clang-21
cpp_compiler: clang++-21
target: x86_64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: MinSizeRel
ccache-variant: sccache
c_compiler: clang-21
cpp_compiler: clang++-21
target: x86_64-unknown-linux-llvm
include_scudo: ON
# TODO: remove ccache logic when https://github.com/hendrikmuhs/ccache-action/issues/279 is resolved.
- os: ubuntu-24.04-arm
build_type: Debug
ccache-variant: ccache
c_compiler: clang-21
cpp_compiler: clang++-21
target: aarch64-unknown-linux-llvm
include_scudo: ON
- os: ubuntu-24.04
build_type: Debug
ccache-variant: ccache
c_compiler: clang-21
cpp_compiler: clang++-21
Expand Down Expand Up @@ -97,7 +115,7 @@ jobs:
-DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }} \
-DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }} \
-DCMAKE_INSTALL_PREFIX=${{ steps.strings.outputs.build-install-dir }} \
-DLLVM_RUNTIMES_TARGET=${{ matrix.target }} \
-DLLVM_RUNTIME_TARGETS=${{ matrix.target }} \
-DLLVM_ENABLE_RUNTIMES="$RUNTIMES" \
-DLLVM_LIBC_FULL_BUILD=ON \
-G Ninja \
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/libc-overlay-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
# Set fail-fast to false to ensure that feedback is delivered for all matrix combinations.
fail-fast: false
matrix:
build_type: [Debug, Release, MinSizeRel]
os: [ubuntu-24.04, ubuntu-24.04-arm, windows-2022, windows-2025, macos-14]
include:
# TODO: add linux gcc when it is fixed
- os: ubuntu-24.04
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
cmake -B ${{ steps.strings.outputs.build-output-dir }}
-DCMAKE_CXX_COMPILER=${{ matrix.compiler.cpp_compiler }}
-DCMAKE_C_COMPILER=${{ matrix.compiler.c_compiler }}
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }}
-DCMAKE_BUILD_TYPE=Debug
-DCMAKE_C_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_CXX_COMPILER_LAUNCHER=${{ matrix.ccache-variant }}
-DCMAKE_POLICY_DEFAULT_CMP0141=NEW
Expand All @@ -110,7 +110,6 @@ jobs:
cmake
--build ${{ steps.strings.outputs.build-output-dir }}
--parallel
--config MinSizeRel
--target libc

- name: Test
Expand Down
Loading