[SandboxVectorizer] Use llvm::find (NFC) #143724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm::find allows us to pass a range.
|
@llvm/pr-subscribers-llvm-transforms Author: Kazu Hirata (kazutakahirata) Changesllvm::find allows us to pass a range. Full diff: https://github.com/llvm/llvm-project/pull/143724.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
index d4cb34647cf55..6d2144b14bb00 100644
--- a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
+++ b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
@@ -68,7 +68,7 @@ class SeedBundle {
/// the seeds in a bundle. This allows constant time evaluation
/// and "removal" from the list.
void setUsed(Instruction *I) {
- auto It = std::find(begin(), end(), I);
+ auto It = llvm::find(*this, I);
assert(It != end() && "Instruction not in the bundle!");
auto Idx = It - begin();
setUsed(Idx, 1, /*VerifyUnused=*/false);
|
|
@llvm/pr-subscribers-vectorizers Author: Kazu Hirata (kazutakahirata) Changesllvm::find allows us to pass a range. Full diff: https://github.com/llvm/llvm-project/pull/143724.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
index d4cb34647cf55..6d2144b14bb00 100644
--- a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
+++ b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/SeedCollector.h
@@ -68,7 +68,7 @@ class SeedBundle {
/// the seeds in a bundle. This allows constant time evaluation
/// and "removal" from the list.
void setUsed(Instruction *I) {
- auto It = std::find(begin(), end(), I);
+ auto It = llvm::find(*this, I);
assert(It != end() && "Instruction not in the bundle!");
auto Idx = It - begin();
setUsed(Idx, 1, /*VerifyUnused=*/false);
|
tgymnich
approved these changes
Jun 11, 2025
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
llvm::find allows us to pass a range.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
llvm::find allows us to pass a range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm::find allows us to pass a range.