Skip to content

Workaround MSVC Linker Issue when Cross-Compiling for ARM64EC #143659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Workaround MSVC Linker Issue when Cross-Compiling for ARM64EC #143659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion llvm/include/llvm/IR/Mangler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,16 @@ class Triple;
class Twine;
class raw_ostream;

constexpr std::string_view HybridPatchableTargetSuffix = "$hp_target";
// TODO: The weird assignment of HybridPatchableTargetSuffix below is a
// temporary workaround for a linker failure that is only hit when compiling
// llvm for arm64ec on windows. The description and context of the issue is at
// https://github.com/llvm/llvm-project/issues/143575.
// An upstream MSVC bug is filed at
// https://developercommunity.visualstudio.com/t/MSVC-Linker-Issue-When-Cross-
// Compiling-L/10920141.
constexpr char HybridPatchableTargetSuffixArr[] = "$hp_target";
constexpr std::string_view HybridPatchableTargetSuffix =
HybridPatchableTargetSuffixArr;

class Mangler {
/// We need to give global values the same name every time they are mangled.
Expand Down
Loading