Skip to content

[OpenMP] Improve performance of ticket lock (x86) #143557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[OpenMP] Improve performance of ticket lock (x86) #143557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8c9131
[OpenMP] Improve performance of ticket lock (x86)
jpeyton52 Jun 10, 2025
403c58f
Remove the distance variable as suggested by Hansang
jpeyton52 Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions openmp/runtime/src/kmp_lock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,16 +712,9 @@ static int __kmp_test_ticket_lock_with_checks(kmp_ticket_lock_t *lck,
}

int __kmp_release_ticket_lock(kmp_ticket_lock_t *lck, kmp_int32 gtid) {
kmp_uint32 distance = std::atomic_load_explicit(&lck->lk.next_ticket,
std::memory_order_relaxed) -
std::atomic_load_explicit(&lck->lk.now_serving,
std::memory_order_relaxed);

std::atomic_fetch_add_explicit(&lck->lk.now_serving, 1U,
std::memory_order_release);

KMP_YIELD(distance >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove line 715--718?

(kmp_uint32)(__kmp_avail_proc ? __kmp_avail_proc : __kmp_xproc));
return KMP_LOCK_RELEASED;
}

Expand Down
Loading