modulemap: add arm64 intrinsics header #142653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-clang Author: Fabrice de Gans (Steelskin) ChangesThe header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers. Full diff: https://github.com/llvm/llvm-project/pull/142653.diff 1 Files Affected:
diff --git a/clang/lib/Headers/module.modulemap b/clang/lib/Headers/module.modulemap
index 35897a3ed0e79..8951fcc2c036c 100644
--- a/clang/lib/Headers/module.modulemap
+++ b/clang/lib/Headers/module.modulemap
@@ -35,6 +35,13 @@ module _Builtin_intrinsics [system] [extern_c] {
}
}
+ explicit module arm64 {
+ requires arm64
+
+ header "arm64intr.h"
+ export *
+ }
+
explicit module intel {
requires x86
export *
|
The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers.
Steelskin
force-pushed
the
fabrice/add-arm64-intrinsics-module
branch
from
3324034 to
bd1690f
Compare
compnerd
approved these changes
Jun 3, 2025
Steelskin
added a commit
to Steelskin/llvm-project
that referenced
this pull request
Jun 4, 2025
The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers. (cherry-picked from commit llvm/llvm-project@50c5704)
rorth
pushed a commit
to rorth/llvm-project
that referenced
this pull request
Jun 11, 2025
The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers.
DhruvSrivastavaX
pushed a commit
to DhruvSrivastavaX/lldb-for-aix
that referenced
this pull request
Jun 12, 2025
The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers.
compnerd
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jun 12, 2025
…module-map 🍒 modulemap: add arm64 intrinsics header (llvm#142653)
Steelskin
added a commit
to Steelskin/llvm-project
that referenced
this pull request
Jun 12, 2025
The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers. (cherry-picked from commit llvm/llvm-project@50c5704)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header was missing from the modulemap definition, resulting in a breakage for Swift with recent Windows SDK headers.