Skip to content

[mlir][llvm] Respect call noinline attr in inliner #134493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

[mlir][llvm] Respect call noinline attr in inliner #134493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mlir/lib/Dialect/LLVMIR/Transforms/InlinerInterfaceImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,11 +664,16 @@ struct LLVMInlinerInterface : public DialectInlinerInterface {

bool isLegalToInline(Operation *call, Operation *callable,
bool wouldBeCloned) const final {
if (!isa<LLVM::CallOp>(call)) {
auto callOp = dyn_cast<LLVM::CallOp>(call);
if (!callOp) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline: call is not an '"
<< LLVM::CallOp::getOperationName() << "' op\n");
return false;
}
if (callOp.getNoInline()) {
LLVM_DEBUG(llvm::dbgs() << "Cannot inline: call is marked no_inline\n");
return false;
}
auto funcOp = dyn_cast<LLVM::LLVMFuncOp>(callable);
if (!funcOp) {
LLVM_DEBUG(llvm::dbgs()
Expand Down
4 changes: 2 additions & 2 deletions mlir/test/Dialect/LLVMIR/inlining.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ llvm.func @foo() -> (i32) attributes { no_inline } {
llvm.return %0 : i32
}

llvm.func @bar() -> (i32) attributes { no_inline } {
llvm.func @bar() -> (i32) {
%0 = llvm.mlir.constant(1 : i32) : i32
llvm.return %0 : i32
}
Expand All @@ -106,7 +106,7 @@ llvm.func @callee_with_multiple_blocks(%cond: i1) -> (i32) {
%0 = llvm.call @foo() : () -> (i32)
llvm.br ^bb3(%0: i32)
^bb2:
%1 = llvm.call @bar() : () -> (i32)
%1 = llvm.call @bar() { no_inline } : () -> (i32)
llvm.br ^bb3(%1: i32)
^bb3(%arg: i32):
llvm.return %arg : i32
Expand Down
Loading