Skip to content

[AST] Avoid repeated hash lookups (NFC) #126400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2025
Merged

[AST] Avoid repeated hash lookups (NFC) #126400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions clang/lib/AST/VTableBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,12 +1169,13 @@ void ItaniumVTableBuilder::ComputeThisAdjustments() {
//
// Do not set ThunkInfo::Method if Idx is already in VTableThunks. This
// can happen when covariant return adjustment is required too.
if (!VTableThunks.count(Idx)) {
auto [It, Inserted] = VTableThunks.try_emplace(Idx);
if (Inserted) {
const CXXMethodDecl *Method = VTables.findOriginalMethodInMap(MD);
VTableThunks[Idx].Method = Method;
VTableThunks[Idx].ThisType = Method->getThisType().getTypePtr();
It->second.Method = Method;
It->second.ThisType = Method->getThisType().getTypePtr();
}
VTableThunks[Idx].This = ThisAdjustment;
It->second.This = ThisAdjustment;
};

SetThisAdjustmentThunk(VTableIndex);
Expand Down Expand Up @@ -1653,8 +1654,9 @@ void ItaniumVTableBuilder::AddMethods(
// findOriginalMethod to find the method that created the entry if the
// method in the entry requires adjustment.
if (!ReturnAdjustment.isEmpty()) {
VTableThunks[Components.size()].Method = MD;
VTableThunks[Components.size()].ThisType = MD->getThisType().getTypePtr();
auto &VTT = VTableThunks[Components.size()];
VTT.Method = MD;
VTT.ThisType = MD->getThisType().getTypePtr();
}

AddMethod(Overrider.Method, ReturnAdjustment);
Expand Down