Skip to content

PeepholeOpt: Remove check for subreg index on a def operand #123943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

PeepholeOpt: Remove check for subreg index on a def operand #123943

merged 1 commit into from
Jan 23, 2025

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Jan 22, 2025

This is looking at operand 0 of a REG_SEQUENCE, which can never
have a subregister index.

This was referenced Jan 22, 2025
Merged
Merged
@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arsenm arsenm marked this pull request as ready for review January 22, 2025 13:34
@arsenm arsenm mentioned this pull request Jan 22, 2025
Merged
qcolombet
qcolombet approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@qcolombet qcolombet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@arsenm Graphite App
Copy link
Contributor Author

arsenm commented Jan 23, 2025 •
edited
Loading

Merge activity

  • Jan 22, 8:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 22, 9:00 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 9:04 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 22, 9:06 PM EST: A user merged this pull request with Graphite.

@arsenm arsenm force-pushed the users/arsenm/peephole-opt-avoid-allocating-small-helper-structs branch from 86973bb to c4c0592 Compare January 23, 2025 01:57
Base automatically changed from users/arsenm/peephole-opt-avoid-allocating-small-helper-structs to main January 23, 2025 02:00
@arsenm arsenm force-pushed the users/arsenm/peephole-opt-remove-check-for-subreg-defs branch from 1e96d7e to 1d4f11d Compare January 23, 2025 02:00
@arsenm
PeepholeOpt: Remove check for subreg index on a def operand
af9e4de 
This is looking at operand 0 of a REG_SEQUENCE, which can never
have a subregister index.
@arsenm arsenm force-pushed the users/arsenm/peephole-opt-remove-check-for-subreg-defs branch from 1d4f11d to af9e4de Compare January 23, 2025 02:04
@arsenm arsenm merged commit 15c2d4b into main Jan 23, 2025
5 of 7 checks passed
@arsenm arsenm deleted the users/arsenm/peephole-opt-remove-check-for-subreg-defs branch January 23, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayfoad jayfoad jayfoad approved these changes

@qcolombet qcolombet qcolombet approved these changes

@kparzysz kparzysz Awaiting requested review from kparzysz

@MatzeB MatzeB Awaiting requested review from MatzeB

Assignees
No one assigned
Labels
llvm:codegen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arsenm @jayfoad @qcolombet