Skip to content

[libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. #123449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2025
Merged

[libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. #123449

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f850478
[libcxx][test] Fix a test for the range of file offsets on ARMv7 targ…
vvereschaka Jan 18, 2025
59b0b25
Fixed formatting
vvereschaka Jan 18, 2025
3d17650
Mark the test as UNSUPPORTED for the armv7-unknown-linux-gnueabihf ta…
vvereschaka Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@
//
// XFAIL: target=powerpc-{{.+}}-aix{{.*}}

// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems,
// meaning it can represent file sizes up to 2GB (2^31 bytes) only.
//
// XFAIL: target=armv7{{.*}}-{{.+}}-linux{{.*}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reasoning looks and sounds reasonable… however it doesn’t seem to hold universally, because we do have some existing CI test configurations that also run on armv7 Linux, where this test does pass. It didn’t trigger this XFAIL though, because the triple has a slightly different form - target=armv7l-linux-gnueabihf, so there’s no vendor field. If you’d tweak the regex to not require a vendor field, I think it would match - and this XFAIL would trigger…

Apparently that setup has got 64 bit off_t by default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, ok. I have marked this test as UNSUPPORTED for armv7-unknown-linux-gnueabihf targets in that case. It will fix the failed test on the public buildbot, that is broken for more than 3 days already.

https://lab.llvm.org/buildbot/#/builders/38
https://lab.llvm.org/buildbot/#/builders/38/builds/1865/steps/15/logs/stdio

Apparently that setup has got 64 bit off_t by default?

The buildbot's ARMv7 board setup has 32-bit off_t by default (as it expected):

ubuntu@jetson6:~$ ./t.tmp.exe
__WORDSIZE: 32
sizeof(off_t): 4
^C


#include <fstream>
#include <iostream>
#include <cassert>
Expand Down
Loading