Skip to content

[libc][complex] enable CFP128 entrypoints on X86_64 #121111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2024
Merged

[libc][complex] enable CFP128 entrypoints on X86_64 #121111

merged 1 commit into from
Dec 25, 2024

Conversation

Sh0g0-1758
Copy link
Member

No description provided.

@llvmbot llvmbot added the libc label Dec 25, 2024
@Sh0g0-1758 Sh0g0-1758 changed the title [libc][complex] enable entrypoints for CFP128 functions on X86_64 [libc][complex] enable CFP128 entrypoints on X86_64 Dec 25, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 25, 2024

@llvm/pr-subscribers-libc

Author: Shourya Goel (Sh0g0-1758)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/121111.diff

1 Files Affected:

  • (modified) libc/config/linux/x86_64/entrypoints.txt (+4-4)
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index 08d8559d8c81a2..94f58b85a6e028 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -739,10 +739,10 @@ endif()
 if(LIBC_TYPES_HAS_FLOAT128)
   list(APPEND TARGET_LIBM_ENTRYPOINTS
     # complex.h C23 _Complex _Float128 entrypoints
-    # libc.src.complex.crealf128
-    # libc.src.complex.cimagf128
-    # libc.src.complex.conjf128
-    # libc.src.complex.cprojf128
+    libc.src.complex.crealf128
+    libc.src.complex.cimagf128
+    libc.src.complex.conjf128
+    libc.src.complex.cprojf128
     
     # math.h C23 _Float128 entrypoints
     libc.src.math.canonicalizef128

@Sh0g0-1758 Sh0g0-1758 merged commit dd9c5c1 into llvm:main Dec 25, 2024
13 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 25, 2024

LLVM Buildbot has detected a new failure on builder libc-x86_64-debian-gcc-fullbuild-dbg running on libc-x86_64-debian-fullbuild while building libc at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/131/builds/13007

Here is the relevant piece of the build log for the reference 
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/libc-linux.py ...' (failure)
...
[       OK ] LlvmLibcStringTest.ResizeCapacityAndNullTermination (5 us)
[ RUN      ] LlvmLibcStringTest.ConcatWithCString
[       OK ] LlvmLibcStringTest.ConcatWithCString (7 us)
[ RUN      ] LlvmLibcStringTest.Comparison
[       OK ] LlvmLibcStringTest.Comparison (7 us)
[ RUN      ] LlvmLibcStringTest.ToString
[       OK ] LlvmLibcStringTest.ToString (25 us)
Ran 19 tests.  PASS: 19  FAIL: 0
[1760/4970] Linking CXX executable libc/test/src/complex/libc.test.src.complex.conjf128_test.__unit__.__build__
[1761/4970] Running unit test libc.test.src.complex.conjf128_test.__unit__
FAILED: libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjf128_test.__unit__ /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-gcc-fullbuild-dbg/build/libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjf128_test.__unit__ 
cd /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-gcc-fullbuild-dbg/build/libc/test/src/complex && /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-gcc-fullbuild-dbg/build/libc/test/src/complex/libc.test.src.complex.conjf128_test.__unit__.__build__
No tests run.
[1762/4970] Linking CXX executable libc/test/src/__support/HashTable/libc.test.src.__support.HashTable.table_test.__unit__.__NO_EXPLICIT_SIMD_OPT.__build__
[1763/4970] Linking CXX executable libc/test/src/__support/threads/linux/libc.test.src.__support.threads.linux.raw_mutex_test.__unit__.__build__
[1764/4970] Running unit test libc.test.src.__support.hash_test.__unit__
[==========] Running 4 tests from 1 test suite.
[ RUN      ] LlvmLibcHashTest.SanityCheck
[       OK ] LlvmLibcHashTest.SanityCheck (1 ms)
[ RUN      ] LlvmLibcHashTest.Avalanche
[       OK ] LlvmLibcHashTest.Avalanche (294 ms)
[ RUN      ] LlvmLibcHashTest.UniformLSB
[       OK ] LlvmLibcHashTest.UniformLSB (521 ms)
[ RUN      ] LlvmLibcHashTest.UniformMSB
[       OK ] LlvmLibcHashTest.UniformMSB (191 us)
Ran 4 tests.  PASS: 4  FAIL: 0
[1765/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjl_test.__unit__.__build__.dir/conjl_test.cpp.o
[1766/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cprojf128_test.__unit__.__build__.dir/cprojf128_test.cpp.o
[1767/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjf_test.__unit__.__build__.dir/conjf_test.cpp.o
[1768/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.conj_test.__unit__.__build__.dir/conj_test.cpp.o
[1769/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.crealf128_test.__unit__.__build__.dir/crealf128_test.cpp.o
[1770/4970] Building CXX object libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__unit__.__build__.dir/type_traits_test.cpp.o
[1771/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cproj_test.__unit__.__build__.dir/cproj_test.cpp.o
[1772/4970] Building CXX object libc/test/src/__support/FPUtil/CMakeFiles/libc.test.src.__support.FPUtil.fpbits_test.__unit__.__build__.dir/fpbits_test.cpp.o
[1773/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cprojf_test.__unit__.__build__.dir/cprojf_test.cpp.o
[1774/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.creall_test.__unit__.__build__.dir/creall_test.cpp.o
[1775/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cprojl_test.__unit__.__build__.dir/cprojl_test.cpp.o
[1776/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.crealf_test.__unit__.__build__.dir/crealf_test.cpp.o
[1777/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.creal_test.__unit__.__build__.dir/creal_test.cpp.o
[1778/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimag_test.__unit__.__build__.dir/cimag_test.cpp.o
[1779/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isalnum_test.__unit__.__build__.dir/isalnum_test.cpp.o
[1780/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimagf128_test.__unit__.__build__.dir/cimagf128_test.cpp.o
[1781/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimagl_test.__unit__.__build__.dir/cimagl_test.cpp.o
[1782/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimagf_test.__unit__.__build__.dir/cimagf_test.cpp.o
[1783/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.islower_test.__unit__.__build__.dir/islower_test.cpp.o
[1784/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isalpha_test.__unit__.__build__.dir/isalpha_test.cpp.o
[1785/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isascii_test.__unit__.__build__.dir/isascii_test.cpp.o
[1786/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isblank_test.__unit__.__build__.dir/isblank_test.cpp.o
[1787/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.iscntrl_test.__unit__.__build__.dir/iscntrl_test.cpp.o
Step 8 (libc-unit-tests) failure: libc-unit-tests (failure)
...
[       OK ] LlvmLibcStringTest.ResizeCapacityAndNullTermination (5 us)
[ RUN      ] LlvmLibcStringTest.ConcatWithCString
[       OK ] LlvmLibcStringTest.ConcatWithCString (7 us)
[ RUN      ] LlvmLibcStringTest.Comparison
[       OK ] LlvmLibcStringTest.Comparison (7 us)
[ RUN      ] LlvmLibcStringTest.ToString
[       OK ] LlvmLibcStringTest.ToString (25 us)
Ran 19 tests.  PASS: 19  FAIL: 0
[1760/4970] Linking CXX executable libc/test/src/complex/libc.test.src.complex.conjf128_test.__unit__.__build__
[1761/4970] Running unit test libc.test.src.complex.conjf128_test.__unit__
FAILED: libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjf128_test.__unit__ /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-gcc-fullbuild-dbg/build/libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjf128_test.__unit__ 
cd /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-gcc-fullbuild-dbg/build/libc/test/src/complex && /home/llvm-libc-buildbot/buildbot-worker/libc-x86_64-debian-fullbuild/libc-x86_64-debian-gcc-fullbuild-dbg/build/libc/test/src/complex/libc.test.src.complex.conjf128_test.__unit__.__build__
No tests run.
[1762/4970] Linking CXX executable libc/test/src/__support/HashTable/libc.test.src.__support.HashTable.table_test.__unit__.__NO_EXPLICIT_SIMD_OPT.__build__
[1763/4970] Linking CXX executable libc/test/src/__support/threads/linux/libc.test.src.__support.threads.linux.raw_mutex_test.__unit__.__build__
[1764/4970] Running unit test libc.test.src.__support.hash_test.__unit__
[==========] Running 4 tests from 1 test suite.
[ RUN      ] LlvmLibcHashTest.SanityCheck
[       OK ] LlvmLibcHashTest.SanityCheck (1 ms)
[ RUN      ] LlvmLibcHashTest.Avalanche
[       OK ] LlvmLibcHashTest.Avalanche (294 ms)
[ RUN      ] LlvmLibcHashTest.UniformLSB
[       OK ] LlvmLibcHashTest.UniformLSB (521 ms)
[ RUN      ] LlvmLibcHashTest.UniformMSB
[       OK ] LlvmLibcHashTest.UniformMSB (191 us)
Ran 4 tests.  PASS: 4  FAIL: 0
[1765/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjl_test.__unit__.__build__.dir/conjl_test.cpp.o
[1766/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cprojf128_test.__unit__.__build__.dir/cprojf128_test.cpp.o
[1767/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.conjf_test.__unit__.__build__.dir/conjf_test.cpp.o
[1768/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.conj_test.__unit__.__build__.dir/conj_test.cpp.o
[1769/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.crealf128_test.__unit__.__build__.dir/crealf128_test.cpp.o
[1770/4970] Building CXX object libc/test/src/__support/CPP/CMakeFiles/libc.test.src.__support.CPP.type_traits_test.__unit__.__build__.dir/type_traits_test.cpp.o
[1771/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cproj_test.__unit__.__build__.dir/cproj_test.cpp.o
[1772/4970] Building CXX object libc/test/src/__support/FPUtil/CMakeFiles/libc.test.src.__support.FPUtil.fpbits_test.__unit__.__build__.dir/fpbits_test.cpp.o
[1773/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cprojf_test.__unit__.__build__.dir/cprojf_test.cpp.o
[1774/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.creall_test.__unit__.__build__.dir/creall_test.cpp.o
[1775/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cprojl_test.__unit__.__build__.dir/cprojl_test.cpp.o
[1776/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.crealf_test.__unit__.__build__.dir/crealf_test.cpp.o
[1777/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.creal_test.__unit__.__build__.dir/creal_test.cpp.o
[1778/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimag_test.__unit__.__build__.dir/cimag_test.cpp.o
[1779/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isalnum_test.__unit__.__build__.dir/isalnum_test.cpp.o
[1780/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimagf128_test.__unit__.__build__.dir/cimagf128_test.cpp.o
[1781/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimagl_test.__unit__.__build__.dir/cimagl_test.cpp.o
[1782/4970] Building CXX object libc/test/src/complex/CMakeFiles/libc.test.src.complex.cimagf_test.__unit__.__build__.dir/cimagf_test.cpp.o
[1783/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.islower_test.__unit__.__build__.dir/islower_test.cpp.o
[1784/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isalpha_test.__unit__.__build__.dir/isalpha_test.cpp.o
[1785/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isascii_test.__unit__.__build__.dir/isascii_test.cpp.o
[1786/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.isblank_test.__unit__.__build__.dir/isblank_test.cpp.o
[1787/4970] Building CXX object libc/test/src/ctype/CMakeFiles/libc.test.src.ctype.iscntrl_test.__unit__.__build__.dir/iscntrl_test.cpp.o

Sh0g0-1758 added a commit to Sh0g0-1758/llvm-project that referenced this pull request Dec 25, 2024
@Sh0g0-1758
Revert "[libc][complex] enable CFP128 entrypoints on X86_64 (llvm#121111
6da4df1 
)"

This reverts commit dd9c5c1.
Sh0g0-1758 added a commit that referenced this pull request Dec 25, 2024
@Sh0g0-1758
Revert "[libc][complex] enable CFP128 entrypoints on X86_64 (#121111)" (
ff97daa 
#121113)

This reverts commit dd9c5c1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
libc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sh0g0-1758 @llvmbot @llvm-ci