Skip to content

[clang-tidy] Mention std::forward_list in container-size-empty doc #120701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ namespace clang::tidy::readability {
///
/// The emptiness of a container should be checked using the `empty()` method
/// instead of the `size()`/`length()` method. It shows clearer intent to use
/// `empty()`. Furthermore some containers may implement the `empty()` method
/// but not implement the `size()` or `length()` method. Using `empty()`
/// whenever possible makes it easier to switch to another container in the
/// future.
/// `empty()`. Furthermore some containers (for example, a `std::forward_list`)
/// may implement the `empty()` method but not implement the `size()` or
/// `length()` method. Using `empty()` whenever possible makes it easier to
/// switch to another container in the future.
class ContainerSizeEmptyCheck : public ClangTidyCheck {
public:
ContainerSizeEmptyCheck(StringRef Name, ClangTidyContext *Context);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@ with a call to ``empty()``.

The emptiness of a container should be checked using the ``empty()`` method
instead of the ``size()``/``length()`` method. It shows clearer intent to use
``empty()``. Furthermore some containers may implement the ``empty()`` method
but not implement the ``size()`` or ``length()`` method. Using ``empty()``
whenever possible makes it easier to switch to another container in the future.
``empty()``. Furthermore some containers (for example, a ``std::forward_list``)
may implement the ``empty()`` method but not implement the ``size()`` or
``length()`` method. Using ``empty()`` whenever possible makes it easier to
switch to another container in the future.

The check issues warning if a container has ``empty()`` and ``size()`` or
``length()`` methods matching following signatures:
Expand Down
Loading