Skip to content

[AMDGPU][True16][MC] update vop1 mc test with update script #119778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

[AMDGPU][True16][MC] update vop1 mc test with update script #119778

merged 1 commit into from
Dec 13, 2024

Conversation

broxigarchen
Copy link
Contributor

@broxigarchen broxigarchen commented Dec 12, 2024 •
edited
Loading

This is a NFC change. Update gfx11/gfx12 vop1 test file with the latest update_mc_test_script.py.

Changing the runline of gfx12_asm_vop1.s since llvm.cfg cannot be read by the update script.

This is also preparing for the up-coming true16 change.

@broxigarchen broxigarchen marked this pull request as ready for review December 12, 2024 22:07
@broxigarchen broxigarchen requested a review from Sisyph December 12, 2024 22:07
@llvmbot llvmbot added backend:AMDGPU llvm:mc Machine (object) code labels Dec 12, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 12, 2024 •
edited
Loading

@llvm/pr-subscribers-backend-amdgpu

@llvm/pr-subscribers-mc

Author: Brox Chen (broxigarchen)

Changes

This is a NFC change. Update gfx11/gfx12 vop1 test file with the latest update_mc_test_script.py.

This is also preparing for the up-coming true16 change

Patch is 2.09 MiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/119778.diff

12 Files Affected:

  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_vop1.s (+1219-1218)
  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_vop1_dpp16.s (+939-938)
  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_vop1_dpp8.s (+218-217)
  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp16_from_vop1.s (+983-982)
  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_vop3_dpp8_from_vop1.s (+284-283)
  • (modified) llvm/test/MC/AMDGPU/gfx11_asm_vop3_from_vop1.s (+1215-1214)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_vop1.s (+1231-1233)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_vop1_dpp16.s (+961-960)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_vop1_dpp8.s (+224-223)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_vop3_from_vop1.s (+1243-1242)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_vop3_from_vop1_dpp16.s (+924-923)
  • (modified) llvm/test/MC/AMDGPU/gfx12_asm_vop3_from_vop1_dpp8.s (+258-257)
diff --git a/llvm/test/MC/AMDGPU/gfx11_asm_vop1.s b/llvm/test/MC/AMDGPU/gfx11_asm_vop1.s
index 379ae3de565aab..d998f4388f1f51 100644
--- a/llvm/test/MC/AMDGPU/gfx11_asm_vop1.s
+++ b/llvm/test/MC/AMDGPU/gfx11_asm_vop1.s
@@ -1,3656 +1,3657 @@
+// NOTE: Assertions have been autogenerated by utils/update_mc_test_checks.py UTC_ARGS: --version 5
 // RUN: llvm-mc -triple=amdgcn -mcpu=gfx1100 -mattr=+real-true16,+wavefrontsize32 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
 // RUN: llvm-mc -triple=amdgcn -mcpu=gfx1100 -mattr=+real-true16,+wavefrontsize64 -show-encoding %s | FileCheck --check-prefix=GFX11 %s
 
 v_bfrev_b32_e32 v5, v1
-// GFX11: encoding: [0x01,0x71,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, v1                  ; encoding: [0x01,0x71,0x0a,0x7e]
 
 v_bfrev_b32 v5, v255
-// GFX11: encoding: [0xff,0x71,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, v255                ; encoding: [0xff,0x71,0x0a,0x7e]
 
 v_bfrev_b32 v5, s1
-// GFX11: encoding: [0x01,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, s1                  ; encoding: [0x01,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, s105
-// GFX11: encoding: [0x69,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, s105                ; encoding: [0x69,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, vcc_lo
-// GFX11: encoding: [0x6a,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, vcc_lo              ; encoding: [0x6a,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, vcc_hi
-// GFX11: encoding: [0x6b,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, vcc_hi              ; encoding: [0x6b,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, ttmp15
-// GFX11: encoding: [0x7b,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, ttmp15              ; encoding: [0x7b,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, m0
-// GFX11: encoding: [0x7d,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, m0                  ; encoding: [0x7d,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, exec_lo
-// GFX11: encoding: [0x7e,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, exec_lo             ; encoding: [0x7e,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, exec_hi
-// GFX11: encoding: [0x7f,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, exec_hi             ; encoding: [0x7f,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, null
-// GFX11: encoding: [0x7c,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, null                ; encoding: [0x7c,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, -1
-// GFX11: encoding: [0xc1,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, -1                  ; encoding: [0xc1,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, 0.5
-// GFX11: encoding: [0xf0,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, 0.5                 ; encoding: [0xf0,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v5, src_scc
-// GFX11: encoding: [0xfd,0x70,0x0a,0x7e]
+// GFX11: v_bfrev_b32_e32 v5, src_scc             ; encoding: [0xfd,0x70,0x0a,0x7e]
 
 v_bfrev_b32 v255, 0xaf123456
-// GFX11: encoding: [0xff,0x70,0xfe,0x7f,0x56,0x34,0x12,0xaf]
+// GFX11: v_bfrev_b32_e32 v255, 0xaf123456        ; encoding: [0xff,0x70,0xfe,0x7f,0x56,0x34,0x12,0xaf]
 
 v_ceil_f16 v5.l, v1.l
-// GFX11: encoding: [0x01,0xb9,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, v1.l               ; encoding: [0x01,0xb9,0x0a,0x7e]
 
 v_ceil_f16 v5.l, v127.l
-// GFX11: encoding: [0x7f,0xb9,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, v127.l             ; encoding: [0x7f,0xb9,0x0a,0x7e]
 
 v_ceil_f16 v5.l, v1.h
-// GFX11: encoding: [0x81,0xb9,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, v1.h               ; encoding: [0x81,0xb9,0x0a,0x7e]
 
 v_ceil_f16 v5.l, v127.h
-// GFX11: encoding: [0xff,0xb9,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, v127.h             ; encoding: [0xff,0xb9,0x0a,0x7e]
 
 v_ceil_f16 v5.l, s1
-// GFX11: encoding: [0x01,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, s1                 ; encoding: [0x01,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, s105
-// GFX11: encoding: [0x69,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, s105               ; encoding: [0x69,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, vcc_lo
-// GFX11: encoding: [0x6a,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, vcc_lo             ; encoding: [0x6a,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, vcc_hi
-// GFX11: encoding: [0x6b,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, vcc_hi             ; encoding: [0x6b,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, ttmp15
-// GFX11: encoding: [0x7b,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, ttmp15             ; encoding: [0x7b,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, m0
-// GFX11: encoding: [0x7d,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, m0                 ; encoding: [0x7d,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, exec_lo
-// GFX11: encoding: [0x7e,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, exec_lo            ; encoding: [0x7e,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, exec_hi
-// GFX11: encoding: [0x7f,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, exec_hi            ; encoding: [0x7f,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, null
-// GFX11: encoding: [0x7c,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, null               ; encoding: [0x7c,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v5.l, -1
-// GFX11: encoding: [0xc1,0xb8,0x0a,0x7e]
+// GFX11: v_ceil_f16_e32 v5.l, -1                 ; encoding: [0xc1,0xb8,0x0a,0x7e]
 
 v_ceil_f16 v127.l, 0.5
-// GFX11: encoding: [0xf0,0xb8,0xfe,0x7e]
+// GFX11: v_ceil_f16_e32 v127.l, 0.5              ; encoding: [0xf0,0xb8,0xfe,0x7e]
 
 v_ceil_f16 v5.h, src_scc
-// GFX11: encoding: [0xfd,0xb8,0x0a,0x7f]
+// GFX11: v_ceil_f16_e32 v5.h, src_scc            ; encoding: [0xfd,0xb8,0x0a,0x7f]
 
 v_ceil_f16 v127.h, 0xfe0b
-// GFX11: encoding: [0xff,0xb8,0xfe,0x7f,0x0b,0xfe,0x00,0x00]
+// GFX11: v_ceil_f16_e32 v127.h, 0xfe0b           ; encoding: [0xff,0xb8,0xfe,0x7f,0x0b,0xfe,0x00,0x00]
 
 v_ceil_f32 v5, v1
-// GFX11: encoding: [0x01,0x45,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, v1                   ; encoding: [0x01,0x45,0x0a,0x7e]
 
 v_ceil_f32 v5, v255
-// GFX11: encoding: [0xff,0x45,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, v255                 ; encoding: [0xff,0x45,0x0a,0x7e]
 
 v_ceil_f32 v5, s1
-// GFX11: encoding: [0x01,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, s1                   ; encoding: [0x01,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, s105
-// GFX11: encoding: [0x69,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, s105                 ; encoding: [0x69,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, vcc_lo
-// GFX11: encoding: [0x6a,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, vcc_lo               ; encoding: [0x6a,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, vcc_hi
-// GFX11: encoding: [0x6b,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, vcc_hi               ; encoding: [0x6b,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, ttmp15
-// GFX11: encoding: [0x7b,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, ttmp15               ; encoding: [0x7b,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, m0
-// GFX11: encoding: [0x7d,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, m0                   ; encoding: [0x7d,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, exec_lo
-// GFX11: encoding: [0x7e,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, exec_lo              ; encoding: [0x7e,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, exec_hi
-// GFX11: encoding: [0x7f,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, exec_hi              ; encoding: [0x7f,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, null
-// GFX11: encoding: [0x7c,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, null                 ; encoding: [0x7c,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, -1
-// GFX11: encoding: [0xc1,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, -1                   ; encoding: [0xc1,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, 0.5
-// GFX11: encoding: [0xf0,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, 0.5                  ; encoding: [0xf0,0x44,0x0a,0x7e]
 
 v_ceil_f32 v5, src_scc
-// GFX11: encoding: [0xfd,0x44,0x0a,0x7e]
+// GFX11: v_ceil_f32_e32 v5, src_scc              ; encoding: [0xfd,0x44,0x0a,0x7e]
 
 v_ceil_f32 v255, 0xaf123456
-// GFX11: encoding: [0xff,0x44,0xfe,0x7f,0x56,0x34,0x12,0xaf]
+// GFX11: v_ceil_f32_e32 v255, 0xaf123456         ; encoding: [0xff,0x44,0xfe,0x7f,0x56,0x34,0x12,0xaf]
 
 v_ceil_f64 v[5:6], v[1:2]
-// GFX11: encoding: [0x01,0x31,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], v[1:2]           ; encoding: [0x01,0x31,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], v[254:255]
-// GFX11: encoding: [0xfe,0x31,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], v[254:255]       ; encoding: [0xfe,0x31,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], s[2:3]
-// GFX11: encoding: [0x02,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], s[2:3]           ; encoding: [0x02,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], s[104:105]
-// GFX11: encoding: [0x68,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], s[104:105]       ; encoding: [0x68,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], vcc
-// GFX11: encoding: [0x6a,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], vcc              ; encoding: [0x6a,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], ttmp[14:15]
-// GFX11: encoding: [0x7a,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], ttmp[14:15]      ; encoding: [0x7a,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], exec
-// GFX11: encoding: [0x7e,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], exec             ; encoding: [0x7e,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], null
-// GFX11: encoding: [0x7c,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], null             ; encoding: [0x7c,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], -1
-// GFX11: encoding: [0xc1,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], -1               ; encoding: [0xc1,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], 0.5
-// GFX11: encoding: [0xf0,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], 0.5              ; encoding: [0xf0,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[5:6], src_scc
-// GFX11: encoding: [0xfd,0x30,0x0a,0x7e]
+// GFX11: v_ceil_f64_e32 v[5:6], src_scc          ; encoding: [0xfd,0x30,0x0a,0x7e]
 
 v_ceil_f64 v[254:255], 0xaf123456
-// GFX11: encoding: [0xff,0x30,0xfc,0x7f,0x56,0x34,0x12,0xaf]
+// GFX11: v_ceil_f64_e32 v[254:255], 0xaf123456   ; encoding: [0xff,0x30,0xfc,0x7f,0x56,0x34,0x12,0xaf]
 
 v_cls_i32 v5, v1
-// GFX11: encoding: [0x01,0x77,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, v1                    ; encoding: [0x01,0x77,0x0a,0x7e]
 
 v_cls_i32 v5, v255
-// GFX11: encoding: [0xff,0x77,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, v255                  ; encoding: [0xff,0x77,0x0a,0x7e]
 
 v_cls_i32 v5, s1
-// GFX11: encoding: [0x01,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, s1                    ; encoding: [0x01,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, s105
-// GFX11: encoding: [0x69,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, s105                  ; encoding: [0x69,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, vcc_lo
-// GFX11: encoding: [0x6a,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, vcc_lo                ; encoding: [0x6a,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, vcc_hi
-// GFX11: encoding: [0x6b,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, vcc_hi                ; encoding: [0x6b,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, ttmp15
-// GFX11: encoding: [0x7b,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, ttmp15                ; encoding: [0x7b,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, m0
-// GFX11: encoding: [0x7d,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, m0                    ; encoding: [0x7d,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, exec_lo
-// GFX11: encoding: [0x7e,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, exec_lo               ; encoding: [0x7e,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, exec_hi
-// GFX11: encoding: [0x7f,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, exec_hi               ; encoding: [0x7f,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, null
-// GFX11: encoding: [0x7c,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, null                  ; encoding: [0x7c,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, -1
-// GFX11: encoding: [0xc1,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, -1                    ; encoding: [0xc1,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, 0.5
-// GFX11: encoding: [0xf0,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, 0.5                   ; encoding: [0xf0,0x76,0x0a,0x7e]
 
 v_cls_i32 v5, src_scc
-// GFX11: encoding: [0xfd,0x76,0x0a,0x7e]
+// GFX11: v_cls_i32_e32 v5, src_scc               ; encoding: [0xfd,0x76,0x0a,0x7e]
 
 v_cls_i32 v255, 0xaf123456
-// GFX11: encoding: [0xff,0x76,0xfe,0x7f,0x56,0x34,0x12,0xaf]
+// GFX11: v_cls_i32_e32 v255, 0xaf123456          ; encoding: [0xff,0x76,0xfe,0x7f,0x56,0x34,0x12,0xaf]
 
 v_clz_i32_u32 v5, v1
-// GFX11: encoding: [0x01,0x73,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, v1                ; encoding: [0x01,0x73,0x0a,0x7e]
 
 v_clz_i32_u32 v5, v255
-// GFX11: encoding: [0xff,0x73,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, v255              ; encoding: [0xff,0x73,0x0a,0x7e]
 
 v_clz_i32_u32 v5, s1
-// GFX11: encoding: [0x01,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, s1                ; encoding: [0x01,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, s105
-// GFX11: encoding: [0x69,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, s105              ; encoding: [0x69,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, vcc_lo
-// GFX11: encoding: [0x6a,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, vcc_lo            ; encoding: [0x6a,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, vcc_hi
-// GFX11: encoding: [0x6b,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, vcc_hi            ; encoding: [0x6b,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, ttmp15
-// GFX11: encoding: [0x7b,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, ttmp15            ; encoding: [0x7b,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, m0
-// GFX11: encoding: [0x7d,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, m0                ; encoding: [0x7d,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, exec_lo
-// GFX11: encoding: [0x7e,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, exec_lo           ; encoding: [0x7e,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, exec_hi
-// GFX11: encoding: [0x7f,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, exec_hi           ; encoding: [0x7f,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, null
-// GFX11: encoding: [0x7c,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, null              ; encoding: [0x7c,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, -1
-// GFX11: encoding: [0xc1,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, -1                ; encoding: [0xc1,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, 0.5
-// GFX11: encoding: [0xf0,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, 0.5               ; encoding: [0xf0,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v5, src_scc
-// GFX11: encoding: [0xfd,0x72,0x0a,0x7e]
+// GFX11: v_clz_i32_u32_e32 v5, src_scc           ; encoding: [0xfd,0x72,0x0a,0x7e]
 
 v_clz_i32_u32 v255, 0xaf123456
-// GFX11: encoding: [0xff,0x72,0xfe,0x7f,0x56,0x34,0x12,0xaf]
+// GFX11: v_clz_i32_u32_e32 v255, 0xaf123456      ; encoding: [0xff,0x72,0xfe,0x7f,0x56,0x34,0x12,0xaf]
 
 v_cos_f16 v5, v1
-// GFX11: encoding: [0x01,0xc3,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, v1                    ; encoding: [0x01,0xc3,0x0a,0x7e]
 
 v_cos_f16 v5, v127
-// GFX11: encoding: [0x7f,0xc3,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, v127                  ; encoding: [0x7f,0xc3,0x0a,0x7e]
 
 v_cos_f16 v5, s1
-// GFX11: encoding: [0x01,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, s1                    ; encoding: [0x01,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, s105
-// GFX11: encoding: [0x69,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, s105                  ; encoding: [0x69,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, vcc_lo
-// GFX11: encoding: [0x6a,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, vcc_lo                ; encoding: [0x6a,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, vcc_hi
-// GFX11: encoding: [0x6b,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, vcc_hi                ; encoding: [0x6b,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, ttmp15
-// GFX11: encoding: [0x7b,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, ttmp15                ; encoding: [0x7b,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, m0
-// GFX11: encoding: [0x7d,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, m0                    ; encoding: [0x7d,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, exec_lo
-// GFX11: encoding: [0x7e,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, exec_lo               ; encoding: [0x7e,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, exec_hi
-// GFX11: encoding: [0x7f,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, exec_hi               ; encoding: [0x7f,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, null
-// GFX11: encoding: [0x7c,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, null                  ; encoding: [0x7c,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, -1
-// GFX11: encoding: [0xc1,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, -1                    ; encoding: [0xc1,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, 0.5
-// GFX11: encoding: [0xf0,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, 0.5                   ; encoding: [0xf0,0xc2,0x0a,0x7e]
 
 v_cos_f16 v5, src_scc
-// GFX11: encoding: [0xfd,0xc2,0x0a,0x7e]
+// GFX11: v_cos_f16_e32 v5, src_scc               ; encoding: [0xfd,0xc2,0x0a,0x7e]
 
 v_cos_f16 v127, 0xfe0b
-// GFX11: encoding: [0xff,0xc2,0xfe,0x7e,0x0b,0xfe,0x00,0x00]
+// GFX11: v_cos_f16_e32 v127, 0xfe0b              ; encoding: [0xff,0xc2,0xfe,0x7e,0x0b,0xfe,0x00,0x00]
 
 v_cos_f32 v5, v1
-// GFX11: encoding: [0x01,0x6d,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, v1                    ; encoding: [0x01,0x6d,0x0a,0x7e]
 
 v_cos_f32 v5, v255
-// GFX11: encoding: [0xff,0x6d,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, v255                  ; encoding: [0xff,0x6d,0x0a,0x7e]
 
 v_cos_f32 v5, s1
-// GFX11: encoding: [0x01,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, s1                    ; encoding: [0x01,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, s105
-// GFX11: encoding: [0x69,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, s105                  ; encoding: [0x69,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, vcc_lo
-// GFX11: encoding: [0x6a,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, vcc_lo                ; encoding: [0x6a,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, vcc_hi
-// GFX11: encoding: [0x6b,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, vcc_hi                ; encoding: [0x6b,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, ttmp15
-// GFX11: encoding: [0x7b,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, ttmp15                ; encoding: [0x7b,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, m0
-// GFX11: encoding: [0x7d,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, m0                    ; encoding: [0x7d,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, exec_lo
-// GFX11: encoding: [0x7e,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, exec_lo               ; encoding: [0x7e,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, exec_hi
-// GFX11: encoding: [0x7f,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, exec_hi               ; encoding: [0x7f,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, null
-// GFX11: encoding: [0x7c,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, null                  ; encoding: [0x7c,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, -1
-// GFX11: encoding: [0xc1,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, -1                    ; encoding: [0xc1,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, 0.5
-// GFX11: encoding: [0xf0,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, 0.5                   ; encoding: [0xf0,0x6c,0x0a,0x7e]
 
 v_cos_f32 v5, src_scc
-// GFX11: encoding: [0xfd,0x6c,0x0a,0x7e]
+// GFX11: v_cos_f32_e32 v5, src_scc               ; encoding: [0xfd,0x6c,0x0a,0x7e]
 
 v_cos_f32 v255, 0xaf123456
-// GFX11: encoding: [0xff,0x6c,0xfe,0x7f,0x56,0x34,0x12,0xaf]
+// GFX11: v_cos_f32_e32 v255, 0xaf123456          ; encoding: [0xff,0x6c,0xfe,0x7f,0x56,0x34,0x12,0xaf]
 
 v_ctz_i32_b32 v5, v1
-// GFX11: encoding: [0x01,0x75,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, v1                ; encoding: [0x01,0x75,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, v255
-// GFX11: encoding: [0xff,0x75,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, v255              ; encoding: [0xff,0x75,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, s1
-// GFX11: encoding: [0x01,0x74,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, s1                ; encoding: [0x01,0x74,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, s105
-// GFX11: encoding: [0x69,0x74,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, s105              ; encoding: [0x69,0x74,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, vcc_lo
-// GFX11: encoding: [0x6a,0x74,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, vcc_lo            ; encoding: [0x6a,0x74,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, vcc_hi
-// GFX11: encoding: [0x6b,0x74,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, vcc_hi            ; encoding: [0x6b,0x74,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, ttmp15
-// GFX11: encoding: [0x7b,0x74,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, ttmp15            ; encoding: [0x7b,0x74,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, m0
-// GFX11: encoding: [0x7d,0x74,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, m0                ; encoding: [0x7d,0x74,0x0a,0x7e]
 
 v_ctz_i32_b32 v5, exec_lo
-// GFX11: encoding: [0x7e,0x74,0x0a,0x7e]
+// GFX11: v_ctz_i32_b32_e32 v5, exec_lo...
[truncated]

Sisyph
Sisyph approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Sisyph Sisyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llvm/test/MC/AMDGPU/gfx12_asm_vop1.s
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx1200 -mattr=+wavefrontsize32,+real-true16 -show-encoding -comment-column=0 %s | FileCheck --strict-whitespace --check-prefixes=GFX12,GFX12-ASM %s
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx1200 -mattr=+wavefrontsize32,+real-true16 -show-encoding %s | %extract-encodings | llvm-mc -triple=amdgcn -mcpu=gfx1200 -mattr=+wavefrontsize32,+real-true16 -disassemble -show-encoding -comment-column=0 | FileCheck --strict-whitespace --check-prefixes=GFX12,GFX12-DIS %s
// RUN: llvm-mc -triple=amdgcn -mcpu=gfx1200 -mattr=+wavefrontsize32,+real-true16 -show-encoding %s | grep -oE '\[0x[0-9a-fx,]+\]' | llvm-mc -triple=amdgcn -mcpu=gfx1200 -mattr=+wavefrontsize32,+real-true16 -disassemble -show-encoding -comment-column=0 | FileCheck --strict-whitespace --check-prefixes=GFX12,GFX12-DIS %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kosarev may want to look into this grep vs extract-encodings when he is available. But the round tripping is preserved with this implementation, so LGTM

@broxigarchen broxigarchen merged commit 7db20a0 into llvm:main Dec 13, 2024
8 checks passed
@madanial0 madanial0 mentioned this pull request Dec 18, 2024
Merged
madanial0 added a commit that referenced this pull request Dec 18, 2024
@madanial0
[NFC] update gfx12 vop test to use sed instead of grep (#120458)
0987fcc 
changes from #119778 breaks the
AIX clang ppc64 bot:
https://lab.llvm.org/buildbot/#/builders/64/builds/1714 as `grep -o` is
not supported on AIX and is not POSIX compatible as per:
https://www.unix.com/man-page/posix/1p/grep/

Co-authored-by: Mark Danial <[email protected]>
github-actions bot pushed a commit to arm/arm-toolchain that referenced this pull request Jan 10, 2025
@madanial0 @github-actions
Automerge: [NFC] update gfx12 vop test to use sed instead of grep (#1…
1ead477 
…20458)

changes from llvm/llvm-project#119778 breaks the
AIX clang ppc64 bot:
https://lab.llvm.org/buildbot/#/builders/64/builds/1714 as `grep -o` is
not supported on AIX and is not POSIX compatible as per:
https://www.unix.com/man-page/posix/1p/grep/

Co-authored-by: Mark Danial <[email protected]>
This was referenced Jun 2, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arsenm arsenm arsenm approved these changes

@Sisyph Sisyph Sisyph approved these changes

Assignees
No one assigned
Labels
backend:AMDGPU llvm:mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@broxigarchen @llvmbot @arsenm @Sisyph