-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[AArch64] Make +sve2-aes an alias of +sve2+sve-aes #116026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -473,7 +473,7 @@ void AArch64TargetInfo::getTargetDefines(const LangOptions &Opts, | |
if (HasSVE2p1) | ||
Builder.defineMacro("__ARM_FEATURE_SVE2p1", "1"); | ||
|
||
if (HasSVE2 && HasSVE2AES) | ||
if (HasSVE2 && HasSVEAES) | ||
Builder.defineMacro("__ARM_FEATURE_SVE2_AES", "1"); | ||
|
||
if (HasSVE2 && HasSVE2BitPerm) | ||
|
@@ -769,7 +769,7 @@ bool AArch64TargetInfo::hasFeature(StringRef Feature) const { | |
.Case("f32mm", FPU & SveMode && HasMatmulFP32) | ||
.Case("f64mm", FPU & SveMode && HasMatmulFP64) | ||
.Case("sve2", FPU & SveMode && HasSVE2) | ||
.Case("sve2-pmull128", FPU & SveMode && HasSVE2AES) | ||
.Case("sve-aes", HasSVEAES) | ||
.Case("sve2-bitperm", FPU & SveMode && HasSVE2BitPerm) | ||
.Case("sve2-sha3", FPU & SveMode && HasSVE2SHA3) | ||
.Case("sve2-sm4", FPU & SveMode && HasSVE2SM4) | ||
|
@@ -861,12 +861,10 @@ bool AArch64TargetInfo::handleTargetFeatures(std::vector<std::string> &Features, | |
HasSVE2 = true; | ||
HasSVE2p1 = true; | ||
} | ||
if (Feature == "+sve2-aes") { | ||
if (Feature == "+sve-aes") { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I understand correctly the TargetParser (invoked from the driver or the target attribute parser) will expand the dependencies of |
||
FPU |= NeonMode; | ||
FPU |= SveMode; | ||
HasFullFP16 = true; | ||
HasSVE2 = true; | ||
HasSVE2AES = true; | ||
HasSVEAES = true; | ||
} | ||
if (Feature == "+sve2-sha3") { | ||
FPU |= NeonMode; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function AArch64TargetInfo::hasFeature doesn't seem to be used much. I don't see any particular tests for it neither it is clear whether the stringswitch should be handling backend feature names or command line facing feature names. I bet most of the cases are useless. That said it doesn't seem necessary to add a line for
.Case("sve2-aes", HasSVE2 && HasSVEAES)
I guess.