-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[DXIL] Don't generate per-variable guards for DirectX #106096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -emit-llvm -o - -disable-llvm-passes %s | FileCheck %s | ||
|
||
// Verify that no per variable _Init_thread instructions are emitted for non-trivial static locals | ||
// These would normally be emitted by the MicrosoftCXXABI, but the DirectX backend should exlude them | ||
// Instead, check for the guardvar oparations that should protect the constructor initialization should | ||
// only take place once. | ||
|
||
RWBuffer<int> buf[10]; | ||
|
||
void InitBuf(RWBuffer<int> buf) { | ||
for (unsigned int i = 0; i < 100; i++) | ||
buf[i] = 0; | ||
} | ||
|
||
// CHECK-NOT: _Init_thread_epoch | ||
// CHECK: define internal void @"?main@@YAXXZ" | ||
// CHECK-NEXT: entry: | ||
// CHECK-NEXT: [[Tmp1:%.*]] = alloca %"class.hlsl::RWBuffer" | ||
// CHECK-NEXT: [[Tmp2:%.*]] = load i32, ptr | ||
// CHECK-NEXT: [[Tmp3:%.*]] = and i32 [[Tmp2]], 1 | ||
// CHECK-NEXT: [[Tmp4:%.*]] = icmp eq i32 [[Tmp3]], 0 | ||
// CHECK-NEXT: br i1 [[Tmp4]] | ||
// CHECK-NOT: _Init_thread_header | ||
// CHECK: init: | ||
// CHECK-NEXT: = or i32 [[Tmp2]], 1 | ||
// CHECK-NOT: _Init_thread_footer | ||
|
||
|
||
[shader("compute")] | ||
[numthreads(1,1,1)] | ||
void main() { | ||
// A non-trivially constructed static local will get checks to verify that it is generated just once | ||
static RWBuffer<int> mybuf; | ||
mybuf = buf[0]; | ||
damyanp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
InitBuf(mybuf); | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.