[libc++] `std::fpclassify()` on non-floats that are convertible to float is an error?

[LebedevRI]

I don't know if this is a bug, but it's an inconsistency with libstdc++:
https://godbolt.org/z/dKGxhndEj

[philnik777]

This should indeed be implicitly converted to double according to http://eel.is/c++draft/cmath.syn.

[frederick-vs-ja]

LWG3693 may be related.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Assign the issue to you.
2. Fix the issue locally.
3. Run the test suite locally.
   3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can
   e.g. use make check-clang-ast to only run Clang's AST tests.
4. Create a git commit
5. Run git clang-format HEAD~1 to format your changes.
6. Submit the patch to Phabricator.
   6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

@llvm/issue-subscribers-good-first-issue

[tolikmalibroda]

Is this bug still relevant? I would like to work on it

[ldionne]

Is this bug still relevant? I would like to work on it

Yes, I think it's still relevant! It'd be great if you can work on a PR for it, let us know once you have something!

[tolikmalibroda]

Created PR: #67913

[ldionne]

Closing since #67913 was merged.