[CIR][LowerToLLVM][NFC] Refactor GlobalOpLowering for better readability and maintainability #1525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this comment, the nested if-arms in
GlobalOpLowering
are somewhat confusing and error-prone. This PR simplifies the logic into more straightforward components.Since LLVM's GlobalOp accepts two types of initializers (either an initializer value or an initializer region), we've extracted the decision logic into a separate function called
lowerInitializer
. This function takes two inout arguments:mlir::Attribute &init
(for the attribute value) andbool useInitializerRegion
(as the decision indicator). All code paths then converge at a common epilogue that handles the operation rewriting.The previous implementation for lowering
DataMemberAttr
initializers relied on recursion between MLIR rewrite calls, which made the control flow somewhat opaque. The new version makes this explicit by using a clear self-recursive pattern withinlowerInitializer
.