[CIR][CIRGen] Add more support for __cxa_rethrow #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruteforceboy
force-pushed
the
rethrow-ii
branch
from
37643cb to
154dc91
Compare
bruteforceboy
force-pushed
the
rethrow-ii
branch
from
154dc91 to
9084f9c
Compare
bcardosolopes
requested changes
Feb 14, 2025
bcardosolopes
requested changes
Feb 19, 2025
bcardosolopes
approved these changes
Feb 20, 2025
bcardosolopes
changed the title
bcardosolopes
changed the title
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This is the second part of [PR#1290](#1290), adding initial support for `__cxa_rethrow`. So, the last PR did not support statements that come after the `UnreachableOp` from the `rethrow`, we just ignored them, e.g: ``` struct S { S() {} }; void foo() { int r = 1; try { throw; S s; } catch (...) { ++r; } } ``` This PR fixes this. A few changes: - `rethrow` statements split their block into multiple blocks. - Tests with statements that come after the `rethrow` were added and old ones were modified. Concern: - The `ScopeOp` workaround still exists which I guess was one of the main concerns when we tried in the last PR. As usual, I am open to discussions on this and how to approach it better -:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of PR#1290, adding initial support for
__cxa_rethrow.So, the last PR did not support statements that come after the
UnreachableOpfrom therethrow, we just ignored them, e.g:This PR fixes this.
A few changes:
rethrowstatements split their block into multiple blocks.rethrowwere added and old ones were modified.Concern:
ScopeOpworkaround still exists which I guess was one of the main concerns when we tried in the last PR.As usual, I am open to discussions on this and how to approach it better -:)