Skip to content

Conversation

@fabianschuiki
Copy link
Contributor

I ran into a situation on my machine where yosys was installed, but yosys-abc was not. Since the circt-synth/abc.mlir test only requires yosys-abc, add a separate feature flag and perform and additional check to see if yosys-abc is installed alongside yosys. If it is not, disable that test.

I ran into a situation on my machine where yosys was installed, but
yosys-abc was not. Since the `circt-synth/abc.mlir` test only requires
yosys-abc, add a separate feature flag and perform and additional check
to see if yosys-abc is installed alongside yosys. If it is not, disable
that test.
@fabianschuiki fabianschuiki requested a review from uenoku December 3, 2025 17:14
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fabianschuiki fabianschuiki merged commit e0bd0ec into main Dec 4, 2025
7 checks passed
@fabianschuiki fabianschuiki deleted the fschuiki/yosys-abc-flag branch December 4, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants