[PyCDE] Add support for union types #9242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for union types in PyCDE, enabling hardware designs to use union data structures. Union types complement the existing struct type support by allowing values to be interpreted as different field types.
Key changes:
- Added
UnionTypeclass with field definitions supporting optional offsets - Implemented
UnionSignalfor runtime union value manipulation - Added validation for union field tuple format in C++ bindings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/Bindings/Python/support.py | Added type conversion support for UnionType |
| lib/Bindings/Python/HWModule.cpp | Added validation for union field info tuple format |
| frontends/PyCDE/test/test_pycde_types.py | Added comprehensive tests for UnionType and UnionSignal functionality |
| frontends/PyCDE/src/pycde/types.py | Implemented UnionType class with field management and value creation |
| frontends/PyCDE/src/pycde/signals.py | Implemented UnionSignal class for field access operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.