[ESI][Runtime] Fixing service uniquifaction #9239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken on Windows. Something to do with linking I suspect. So let's just use a string.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes service uniquification issues in the ESI runtime on Windows by replacing std::type_info* with std::string in the service cache key. The change addresses a linking-related problem where using type_info pointers for service identification was broken on Windows.
Key Changes:
- Modified service cache key from using
std::type_info*tostd::stringrepresentation - Updated cache lookup to convert service type to string using
svcType.name()
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/Dialect/ESI/runtime/cpp/include/esi/Accelerator.h | Changed ServiceCacheKey tuple from using type_info pointer to string |
| lib/Dialect/ESI/runtime/cpp/lib/Accelerator.cpp | Updated service cache lookup to use string conversion of service type name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken on Windows. Something to do with linking I suspect. So let's just use a string.