[ESI][Python] Plumb through windows types to Python #9231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds Python bindings for ESI Window types, enabling Python users to create and manipulate WindowType, WindowFrameType, and WindowFieldType objects through the CIRCT Python API.
Key changes:
- Added C API functions for three Window-related types (WindowType, WindowFrameType, WindowFieldType)
- Implemented Python bindings with validation logic for type safety
- Extended type conversion support in Python utilities to handle Window types
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| include/circt-c/Dialect/ESI.h | Added C API declarations for Window types and a struct definition |
| lib/CAPI/Dialect/ESI.cpp | Implemented C API functions for Window type construction and property access |
| lib/Bindings/Python/ESIModule.cpp | Added Python bindings with type validation and property accessors |
| lib/Bindings/Python/support.py | Extended type_to_pytype to handle Window type conversions |
| integration_test/Bindings/Python/dialects/esi.py | Added comprehensive integration tests for Window types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.