[ESI][BSP] Introduce a pipelined channel demux and use it #9202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a half-throughput channel demux. Use it in the ChannelMMIO implementation. Half-thoughput is acceptable since it only supports one message at a time anyway. This was necessary to support even simple internal applications since they weren't anywhere close to meeting timing. Doubtless there'll be more timing enhancements coming down the pike.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new pipelined tree-structured channel demultiplexer implementation to improve scalability for large numbers of outputs in the MMIO subsystem. The new implementation uses half-stage buffering with ready-blocking semantics to reduce area and fanout pressure.
- Adds two new demultiplexer module generators:
ChannelDemuxN_HalfStage_ReadyBlocking(N-way leaf demux) andChannelDemuxTree_HalfStage_ReadyBlocking(tree-structured demux) - Replaces the existing
esi.ChannelDemuxwith the new tree demux in theChannelMMIO.build_readmethod - The new implementation embeds selection signals into the channel payload as structured data
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
Merging without review so as to build the new pycde package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a half-throughput channel demux. Use it in the ChannelMMIO implementation. Half-thoughput is acceptable since it only supports one message at a time anyway.
This was necessary to support even simple internal applications since they weren't anywhere close to meeting timing. Doubtless there'll be more timing enhancements coming down the pike.