[FIRRTL] Add domain support to instance choice #9197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwy7
force-pushed
the
instance-choice-support-domains
branch
from
6902cc3 to
9ea3ac0
Compare
Contributor
Author
|
Something that is bugging me (but not a problem with this PR): we don't know if the choices of an instance_choice op actually have the same domains until after domain inference is run. |
dtzSiFive
approved these changes
Nov 6, 2025
Contributor
dtzSiFive
left a comment
dtzSiFive
left a comment
There was a problem hiding this comment.
Awesome, thanks! LGTM!
rwy7
force-pushed
the
instance-choice-support-domains
branch
from
9ea3ac0 to
1b7bb54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.