[ImportVerilog] Enforce base class elaboration #9181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Nov 5, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM! Would it make sense to add a test where the GenericBar is defined after the SpecializedFoo? IIRC, SV allows for that, and I've managed to code up stuff in the past that would fail if it saw a use before a definition.
Contributor
Author
That would be news to me! Slang throws an error for use before declaration which ever way I try 😅 |
Previously, the compiler could crash when encountering a specialized class extending and specializing a generic class, since no classdecl would be lowered for the generic class. This commit enforces the emission of a classdecl for the specialized version of the generic base class in such a case.
Scheremo
force-pushed
the
pr-class-inheritance-fix
branch
from
c531ea6 to
c04f002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the compiler could crash when encountering a specialized class extending and specializing a generic class, since no classdecl would be lowered for the generic class. This commit enforces the emission of a classdecl for the specialized version of the generic base class in such a case.