[Moore][ImportVerilog] Implement support for virtual functions #9180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-classes-virtual-methods
branch
from
35c60d5 to
cae1185
Compare
Scheremo
force-pushed
the
pr-classes-virtual-methods
branch
3 times, most recently
from
7f7ebd0 to
0abd95f
Compare
fabianschuiki
approved these changes
Nov 5, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM! Just a minor nit regarding non-virtual methods.
Scheremo
force-pushed
the
pr-classes-virtual-methods
branch
3 times, most recently
from
f87e1fd to
73c84ee
Compare
- Introduce `moore.class.methoddecl` **`virtual`** flag. - Add `moore.vtable.load_method` op to fetch a virtual method’s callee. - Importer now emits **indirect calls** for virtual methods; direct calls remain for non-virtual. - Verifier ensures method exists, is `virtual`, and the result **FunctionType** matches the erased ABI. - Tests cover both the `virtual` decl and dynamic dispatch.
Scheremo
force-pushed
the
pr-classes-virtual-methods
branch
from
73c84ee to
cdb31a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moore.class.methoddeclvirtualflag.moore.vtable.load_methodop to fetch a virtual method’s callee.virtual, and the result FunctionType matches the erased ABI.virtualdecl and dynamic dispatch.