[ImportVerilog] Add global variable support #9176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
reviewed
Nov 3, 2025
Add new `moore.global_variable` and `moore.get_global_variable` ops to the Moore dialect, which define global variables as a symbol and return a reference to a global variable given its symbol, respectively. Add support for variables at the root level and within packages in SV inputs. Both of these get converted to `moore.global_variable`s. When referring to a global variable by name, create `get_global_variable` ops to resolve the symbol name to a `!moore.ref<T>` which can then be read. Lowering to the core dialects is not yet supported. We very likely need an equivalent global signal construct in LLHD.
fabianschuiki
force-pushed
the
fschuiki/global-vars
branch
from
3d7688c to
0d93dbc
Compare
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Nov 5, 2025
Add new `moore.global_variable` and `moore.get_global_variable` ops to the Moore dialect, which define global variables as a symbol and return a reference to a global variable given its symbol, respectively. Add support for variables at the root level and within packages in SV inputs. Both of these get converted to `moore.global_variable`s. When referring to a global variable by name, create `get_global_variable` ops to resolve the symbol name to a `!moore.ref<T>` which can then be read. Lowering to the core dialects is not yet supported. We very likely need an equivalent global signal construct in LLHD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
moore.global_variableandmoore.get_global_variableops to the Moore dialect, which define global variables as a symbol and return a reference to a global variable given its symbol, respectively.Add support for variables at the root level and within packages in SV inputs. Both of these get converted to
moore.global_variables. When referring to a global variable by name, createget_global_variableops to resolve the symbol name to a!moore.ref<T>which can then be read.Lowering to the core dialects is not yet supported. We very likely need an equivalent global signal construct in LLHD.