[RTG][Elaboration] Fix incorrect set equality #9175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM. Note that XOR commutative hashing would cause a lot of collision so we might want to revisit later if this hashing is called frequently. FYI Yosys improved the hashing recently YosysHQ/yosys#5302. |
uenoku
approved these changes
Nov 3, 2025
Member
Author
|
Thanks for the pointer! I expect that we'll have to do that or something similar as well, probably not too far in the future. |
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two sets in the added test were not considered equivalent. The order of the set that was internalized first is used for all equivalent sets now.