[Bug][ImportVerilog] [1/2] Add support for class method forward decls #9158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
changed the title
Scheremo
changed the title
Scheremo
force-pushed
the
pr-class-method-forward-decl
branch
from
e460cdf to
c91f703
Compare
fabianschuiki
approved these changes
Oct 30, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
LGTM, modulo minor nits
This commit adds the plumbing to convert `slang::ast::MethodPrototypeSymbol`s corresponding to class method forward declarations. This is done by looking up the implementation and converting it when encountering a forward declaration. This makes sure field order within the class declaration is respected and the emitted `methoddecl`'s signature is correct.
Scheremo
force-pushed
the
pr-class-method-forward-decl
branch
from
c91f703 to
6a0fde0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the plumbing to convert
slang::ast::MethodPrototypeSymbols corresponding to class method forward declarations. This is done by looking up the implementation and converting it when encountering a forward declaration. This makes sure field order within the class declaration is respected and the emittedmethoddecl's signature is correct.It also fixes a bug where the implicit
thisreference argument of method calls would get emitted twice in call sites.