[HWToBTOR2] Add support for (most) variadic ops #9155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like my local clang-format and the version in CI disagree 🤔 |
Contributor
Author
|
Downgrading my clang-format to 17 fixed the issue (current CI failures look unrelated) |
cowardsa
approved these changes
Oct 31, 2025
Contributor
cowardsa
left a comment
cowardsa
left a comment
There was a problem hiding this comment.
LGTM - but not super familiar with this part of CIRCT...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the variadic forms of comb.(add|sub|xor|or|and). I'll add support for unary instantiations and concat in follow-up PRs as they both require special handling.
There's some unrelated diff on some of the BTOR2 printing which I guess is just due to a clang-format change...