[MooreToCore] [1/4] Implement ClassDeclOp -> LLVMStructType conversion #9150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-moore-classes-decl-lowering
branch
from
76f8681 to
b4b774e
Compare
Scheremo
changed the title
Scheremo
changed the title
Scheremo
force-pushed
the
pr-moore-classes-decl-lowering
branch
from
b4b774e to
6efdd37
Compare
Scheremo
changed the title
Scheremo
force-pushed
the
pr-moore-classes-decl-lowering
branch
2 times, most recently
from
04da412 to
a02d30e
Compare
Scheremo
force-pushed
the
pr-moore-classes-decl-lowering
branch
4 times, most recently
from
cdeaaae to
d8520fd
Compare
Add support for converting `moore.class.classdecl` operations into identified LLVM struct types during the MooreToCore lowering. - Introduced **`ClassTypeCache`** for mapping class symbols to LLVM structs and field paths. - Added utilities: - `mangleClassName` generates `moore.class.<name>` identifiers. - `getOrCreateOpaqueStruct` creates identified LLVM struct types. - Implemented `resolveClassStructBody` to: - Lay out classes in **base-first** order. - Convert class properties to LLVM member types. - Inherit base field paths. - Added `ClassDeclOpConversion` to handle class lowering and removal. - Extended type conversion: - `ClassHandleType` -> `!llvm.ptr` - Integrated cache handling into `MooreToCorePass`.
Scheremo
force-pushed
the
pr-moore-classes-decl-lowering
branch
from
d8520fd to
c0199d2
Compare
fabianschuiki
approved these changes
Oct 31, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
Really nice, LGTM! Thanks a lot for getting us closer to SV classes support 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for converting
moore.class.classdecloperations into identified LLVM struct types during the MooreToCore lowering.ClassTypeCachefor mapping class symbols to LLVM structs and field paths.mangleClassNamegeneratesmoore.class.<name>identifiers.getOrCreateOpaqueStructcreates identified LLVM struct types.resolveClassStructBodyto:ClassDeclOpConversionto handle class lowering and removal.ClassHandleType->!llvm.ptrMooreToCorePass.