Skip to content

[MooreToCore] Create implicit zero value for real variables #9147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabianschuiki merged 1 commit into from
Oct 28, 2025
Merged

[MooreToCore] Create implicit zero value for real variables #9147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/Conversion/MooreToCore/MooreToCore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,12 @@ static Value createZeroValue(Type type, Location loc,
return llhd::ConstantTimeOp::create(rewriter, loc, timeAttr);
}

// Handle real values.
if (auto floatType = dyn_cast<FloatType>(type)) {
auto floatAttr = rewriter.getFloatAttr(floatType, 0.0);
return mlir::arith::ConstantOp::create(rewriter, loc, floatAttr);
}

// Otherwise try to create a zero integer and bitcast it to the result type.
int64_t width = hw::getBitWidth(type);
if (width == -1)
Expand Down
8 changes: 8 additions & 0 deletions test/Conversion/MooreToCore/basic.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,14 @@ moore.module @Variable() {
%c42_fs = moore.constant_time 42 fs
moore.variable %c42_fs : <!moore.time>

// CHECK: [[TMP:%.+]] = arith.constant {{0.*}} : f32
// CHECK: llhd.sig [[TMP]] : f32
moore.variable : <!moore.f32>

// CHECK: [[TMP:%.+]] = arith.constant {{0.*}} : f64
// CHECK: llhd.sig [[TMP]] : f64
moore.variable : <!moore.f64>

// CHECK: hw.output
moore.output
}
Expand Down