-
Notifications
You must be signed in to change notification settings - Fork 404
[Moore] [1/4] Implement ClassHandleType, ClassDeclarationOp #9133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c28ece5 to
8259650
Compare
8259650 to
d9202ef
Compare
afd2eba to
09ee6e7
Compare
fabianschuiki
approved these changes
Oct 28, 2025
Contributor
fabianschuiki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really really cool! Thanks a lot for taking a stab at this pretty wild corner of the SV spec 🥳 💯 🥇
09ee6e7 to
1959567
Compare
This change introduces first-class **class** support to the Moore dialect and teaches the Verilog importer to **recognize and lower SV classes** into that IR. It also adds an opaque **class handle type** for values of class objects. - New **IR ops** for classes: declarations, properties, and a class-body terminator. - New **type**: `!moore.class.object<@sym>` (with `ref` variant). - Importer now **creates symbols for classes**, wires up `extends`/`implements`, and lowers **class-typed values** to `!moore.class.object<…>`. - Extensive **tests** for inheritance, interfaces, properties, scoping, and handle declarations.
1959567 to
3f76b49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces first-class class support to the Moore dialect and teaches the Verilog importer to recognize and lower SV classes into that IR. It also adds an opaque class handle type for values of class objects.
!moore.class.object<@Sym>(withrefvariant).extends/implements, and lowers class-typed values to!moore.class.object<…>.