[FIRRTL] Various reduction pattern tweaks #9132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the SimplifyResets reduction pattern, which converts all uninferred resets into synchronous resets and removes any annotations involved in the reset inference pass. This helps later reductions remove module instances without the resets in those modules becoming uninferred.
Since deduplication of classes is being phased out, exclude `firrtl.object` operations from dedup reductions.
Only force-dedup modules if their port signatures truly match. Also, delay removal of modules until the very end. This allows the reduction to deal with malformed input IR a bit better.
Instead of removing MustDedup annotations from parent modules once they were applied to children, keep them around on parents as well. This helps propagate MustDedup all the way to child modules even if the test case relies on the parent module also being marked as dedup. Having redundant MustDedup annos on child modules helps the ForceDedup reduction collapse child modules to one definition, effectively applying a partial dedup.
Contributor
Author
|
Landing this since it only touches circt-reduce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of tweaks and improvements to reduction patterns as I've been debugging a few FIRRTL dedup and class lowering issues. I plan to land this using a rebase merge, not a squash merge, such that the individual independent commits stay separated.