Skip to content

[Synth][LowerVariadic] Fix a dialect dependency #9118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uenoku merged 2 commits into from
Oct 21, 2025
Merged

[Synth][LowerVariadic] Fix a dialect dependency #9118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
773bdde
[Synth][LowerVariadic] Fix a dialect dependency
uenoku Oct 20, 2025
cc2625b
Address comments
uenoku Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/circt/Dialect/Synth/Transforms/SynthPasses.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ def LowerVariadic : Pass<"synth-lower-variadic", "hw::HWModuleOp"> {
Option<"timingAware", "timing-aware", "bool", "true",
"Lower operators with timing information">
];
let dependentDialects = [
"circt::comb::CombDialect", "circt::hw::HWDialect", "circt::synth::SynthDialect"
];
}

def LowerWordToBits : Pass<"synth-lower-word-to-bits", "hw::HWModuleOp"> {
Expand Down
14 changes: 12 additions & 2 deletions test/Dialect/Synth/lower-variadic.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// RUN: circt-opt %s --synth-lower-variadic | FileCheck %s --check-prefixes=COMMON,TIMING
// RUN: circt-opt %s --synth-lower-variadic=timing-aware=false | FileCheck %s --check-prefixes=COMMON,NO-TIMING
// RUN: circt-opt %s --synth-lower-variadic --split-input-file | FileCheck %s --check-prefixes=COMMON,TIMING
// RUN: circt-opt %s --synth-lower-variadic=timing-aware=false --split-input-file | FileCheck %s --check-prefixes=COMMON,NO-TIMING
// COMMON-LABEL: hw.module @Basic
hw.module @Basic(in %a: i2, in %b: i2, in %c: i2, in %d: i2, in %e: i2, out f: i2) {
// COMMON-NEXT: %[[RES0:.+]] = synth.aig.and_inv not %a, %b : i2
Expand Down Expand Up @@ -61,3 +61,13 @@ hw.module @ChildRegion(in %x: i4, in %y: i4, in %z: i4) {
%1 = comb.and %0, %y, %z : i4
}
}

// -----
// Use a different file to check the dialect dependency.
// COMMON-LABEL: hw.module @Issue9115
hw.module @Issue9115(in %a : i16, in %b : i16, in %c : i16, in %d : i16, out product : i16) {
%0 = comb.mul %a, %b, %c : i16
// COMMON-NEXT: %[[TMP:.+]] = comb.mul %a, %b : i16
// COMMON-NEXT: comb.mul %c, %[[TMP]] : i16
hw.output %0 : i16
}