[ImportVerilog] Harden SVReal materialization #9113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes real literal conversion safer and clearer, and adds tests.
- **Direct lowering for AST real literals**
- `RvalueExprVisitor::visit(RealLiteral)` now emits a `moore.real_constant` via an MLIR `FloatAttr` (f64) directly, avoiding the older `materializeSVReal` path.
- **Safer constant folding for reals**
- Reworked `Context::materializeSVReal(...)`:
- Verifies the AST type is floating before proceeding.
- **Coerces** `slang::ConstantValue` to the expected kind (`real`/`shortreal`) using Slang conversions.
- Avoids calling `.real()` / `.shortReal()` unless the corresponding `is*()` predicate holds.
- Emits `moore.real_literal` / `moore.shortreal_literal` with the correct MLIR float type (`f64`/`f32`).
- **`RealLiteral` module** in `basic.sv`
- Checks emission of `moore.real_constant 5.000000e-01`
- Verifies implicit conversion to `shortreal` via a `moore.conversion` from `!moore.f64` → `!moore.f32`
- Confirms variable initializations for both `real` and `shortreal`.
Scheremo
force-pushed
the
pr-fix-svreal
branch
from
4702498 to
921e075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes real literal conversion safer and clearer, and adds tests.
Direct lowering for AST real literals
RvalueExprVisitor::visit(RealLiteral)now emits amoore.real_constantvia an MLIRFloatAttr(f64) directly, avoiding the oldermaterializeSVRealpath.Safer constant folding for reals
Context::materializeSVReal(...):slang::ConstantValueto the expected kind (real/shortreal) using Slang conversions..real()/.shortReal()unless the correspondingis*()predicate holds.moore.real_literal/moore.shortreal_literalwith the correct MLIR float type (f64/f32).RealLiteralmodule inbasic.svmoore.real_constant 5.000000e-01shortrealvia amoore.conversionfrom!moore.f64→!moore.f32realandshortreal.